Skip to content

Commit

Permalink
smsc911x: Fix Console Hang when bringing the interface down.
Browse files Browse the repository at this point in the history
In the NAPI poll function, check for netif_running() is unnecassary.
In addition to associated runtime overhead, it also results in
continuous softirq loop when the interface is brought down under heavy
traffic(tested with Traffic Generator).Once the interface is disabled,
the poll function always returns zero(with the check for netif_running)
and napi_complete() would never get called resulting in softirq loop.

Signed-off-by: Sriramakrishnan <srk@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Sriram authored and David S. Miller committed Nov 16, 2009
1 parent 2c554e1 commit f88c5b9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/smsc911x.c
Original file line number Diff line number Diff line change
Expand Up @@ -986,7 +986,7 @@ static int smsc911x_poll(struct napi_struct *napi, int budget)
struct net_device *dev = pdata->dev;
int npackets = 0;

while (likely(netif_running(dev)) && (npackets < budget)) {
while (npackets < budget) {
unsigned int pktlength;
unsigned int pktwords;
struct sk_buff *skb;
Expand Down

0 comments on commit f88c5b9

Please sign in to comment.