Skip to content

Commit

Permalink
x86, genapic: rename int_delivery_mode, et. al.
Browse files Browse the repository at this point in the history
int_delivery_mode is supposed to mean 'interrupt delivery mode', but
it's quite a misnomer as 'int' we usually think of as an integer type ...

The standard naming for such attributes is 'irq' - so rename the following
fields and macros:

 int_delivery_mode => irq_delivery_mode
 INT_DELIVERY_MODE => IRQ_DELIVERY_MODE
 int_dest_mode     => irq_dest_mode
 INT_DEST_MODE     => IRQ_DEST_MODE

Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Ingo Molnar committed Jan 28, 2009
1 parent 7ed248d commit f8987a1
Show file tree
Hide file tree
Showing 17 changed files with 53 additions and 53 deletions.
4 changes: 2 additions & 2 deletions arch/x86/include/asm/bigsmp/apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ static inline const cpumask_t *target_cpus(void)
#undef APIC_DEST_LOGICAL
#define APIC_DEST_LOGICAL 0
#define APIC_DFR_VALUE (APIC_DFR_FLAT)
#define INT_DELIVERY_MODE (dest_Fixed)
#define INT_DEST_MODE (0) /* phys delivery to target proc */
#define IRQ_DELIVERY_MODE (dest_Fixed)
#define IRQ_DEST_MODE (0) /* phys delivery to target proc */
#define NO_BALANCE_IRQ (0)

static inline unsigned long check_apicid_used(physid_mask_t bitmap, int apicid)
Expand Down
4 changes: 2 additions & 2 deletions arch/x86/include/asm/es7000/apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ static inline const cpumask_t *target_cpus(void)
#define NO_BALANCE_IRQ_CLUSTER (1)

#define APIC_DFR_VALUE (APIC_DFR_FLAT)
#define INT_DELIVERY_MODE (dest_Fixed)
#define INT_DEST_MODE (0) /* phys delivery to target procs */
#define IRQ_DELIVERY_MODE (dest_Fixed)
#define IRQ_DEST_MODE (0) /* phys delivery to target procs */
#define NO_BALANCE_IRQ (0)
#undef APIC_DEST_LOGICAL
#define APIC_DEST_LOGICAL 0x0
Expand Down
4 changes: 2 additions & 2 deletions arch/x86/include/asm/genapic.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ struct genapic {
int (*acpi_madt_oem_check)(char *oem_id, char *oem_table_id);
int (*apic_id_registered)(void);

u32 int_delivery_mode;
u32 int_dest_mode;
u32 irq_delivery_mode;
u32 irq_dest_mode;

const struct cpumask *(*target_cpus)(void);

Expand Down
8 changes: 4 additions & 4 deletions arch/x86/include/asm/mach-default/mach_apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ static inline const struct cpumask *target_cpus(void)

#ifdef CONFIG_X86_64
#include <asm/genapic.h>
#define INT_DELIVERY_MODE (apic->int_delivery_mode)
#define INT_DEST_MODE (apic->int_dest_mode)
#define IRQ_DELIVERY_MODE (apic->irq_delivery_mode)
#define IRQ_DEST_MODE (apic->irq_dest_mode)
#define TARGET_CPUS (apic->target_cpus())
#define init_apic_ldr (apic->init_apic_ldr)
#define cpu_mask_to_apicid (apic->cpu_mask_to_apicid)
Expand All @@ -35,8 +35,8 @@ static inline const struct cpumask *target_cpus(void)
#define wakeup_secondary_cpu (apic->wakeup_cpu)
extern void setup_apic_routing(void);
#else
#define INT_DELIVERY_MODE dest_LowestPrio
#define INT_DEST_MODE 1 /* logical delivery broadcast to all procs */
#define IRQ_DELIVERY_MODE dest_LowestPrio
#define IRQ_DEST_MODE 1 /* logical delivery broadcast to all procs */
#define TARGET_CPUS (target_cpus())
#define wakeup_secondary_cpu wakeup_secondary_cpu_via_init
/*
Expand Down
4 changes: 2 additions & 2 deletions arch/x86/include/asm/mach-generic/mach_apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@

#define esr_disable (apic->ESR_DISABLE)
#define NO_BALANCE_IRQ (apic->no_balance_irq)
#define INT_DELIVERY_MODE (apic->int_delivery_mode)
#define INT_DEST_MODE (apic->int_dest_mode)
#define IRQ_DELIVERY_MODE (apic->irq_delivery_mode)
#define IRQ_DEST_MODE (apic->irq_dest_mode)
#undef APIC_DEST_LOGICAL
#define APIC_DEST_LOGICAL (apic->apic_destination_logical)
#define TARGET_CPUS (apic->target_cpus())
Expand Down
4 changes: 2 additions & 2 deletions arch/x86/include/asm/numaq/apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ static inline const cpumask_t *target_cpus(void)
#define NO_BALANCE_IRQ (1)
#define esr_disable (1)

#define INT_DELIVERY_MODE dest_LowestPrio
#define INT_DEST_MODE 0 /* physical delivery on LOCAL quad */
#define IRQ_DELIVERY_MODE dest_LowestPrio
#define IRQ_DEST_MODE 0 /* physical delivery on LOCAL quad */

static inline unsigned long check_apicid_used(physid_mask_t bitmap, int apicid)
{
Expand Down
4 changes: 2 additions & 2 deletions arch/x86/include/asm/summit/apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ static inline const cpumask_t *target_cpus(void)
return &cpumask_of_cpu(0);
}

#define INT_DELIVERY_MODE (dest_LowestPrio)
#define INT_DEST_MODE 1 /* logical delivery broadcast to all procs */
#define IRQ_DELIVERY_MODE (dest_LowestPrio)
#define IRQ_DEST_MODE 1 /* logical delivery broadcast to all procs */

static inline unsigned long check_apicid_used(physid_mask_t bitmap, int apicid)
{
Expand Down
8 changes: 4 additions & 4 deletions arch/x86/kernel/genapic_flat_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,8 @@ struct genapic apic_flat = {
.acpi_madt_oem_check = flat_acpi_madt_oem_check,
.apic_id_registered = flat_apic_id_registered,

.int_delivery_mode = dest_LowestPrio,
.int_dest_mode = (APIC_DEST_LOGICAL != 0),
.irq_delivery_mode = dest_LowestPrio,
.irq_dest_mode = (APIC_DEST_LOGICAL != 0),

.target_cpus = flat_target_cpus,
.ESR_DISABLE = 0,
Expand Down Expand Up @@ -326,8 +326,8 @@ struct genapic apic_physflat = {
.acpi_madt_oem_check = physflat_acpi_madt_oem_check,
.apic_id_registered = flat_apic_id_registered,

.int_delivery_mode = dest_Fixed,
.int_dest_mode = (APIC_DEST_PHYSICAL != 0),
.irq_delivery_mode = dest_Fixed,
.irq_dest_mode = (APIC_DEST_PHYSICAL != 0),

.target_cpus = physflat_target_cpus,
.ESR_DISABLE = 0,
Expand Down
4 changes: 2 additions & 2 deletions arch/x86/kernel/genx2apic_cluster.c
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,8 @@ struct genapic apic_x2apic_cluster = {
.acpi_madt_oem_check = x2apic_acpi_madt_oem_check,
.apic_id_registered = x2apic_apic_id_registered,

.int_delivery_mode = dest_LowestPrio,
.int_dest_mode = (APIC_DEST_LOGICAL != 0),
.irq_delivery_mode = dest_LowestPrio,
.irq_dest_mode = (APIC_DEST_LOGICAL != 0),

.target_cpus = x2apic_target_cpus,
.ESR_DISABLE = 0,
Expand Down
4 changes: 2 additions & 2 deletions arch/x86/kernel/genx2apic_phys.c
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,8 @@ struct genapic apic_x2apic_phys = {
.acpi_madt_oem_check = x2apic_acpi_madt_oem_check,
.apic_id_registered = x2apic_apic_id_registered,

.int_delivery_mode = dest_Fixed,
.int_dest_mode = (APIC_DEST_PHYSICAL != 0),
.irq_delivery_mode = dest_Fixed,
.irq_dest_mode = (APIC_DEST_PHYSICAL != 0),

.target_cpus = x2apic_target_cpus,
.ESR_DISABLE = 0,
Expand Down
4 changes: 2 additions & 2 deletions arch/x86/kernel/genx2apic_uv_x.c
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,8 @@ struct genapic apic_x2apic_uv_x = {
.acpi_madt_oem_check = uv_acpi_madt_oem_check,
.apic_id_registered = uv_apic_id_registered,

.int_delivery_mode = dest_Fixed,
.int_dest_mode = (APIC_DEST_PHYSICAL != 0),
.irq_delivery_mode = dest_Fixed,
.irq_dest_mode = (APIC_DEST_PHYSICAL != 0),

.target_cpus = uv_target_cpus,
.ESR_DISABLE = 0,
Expand Down
30 changes: 15 additions & 15 deletions arch/x86/kernel/io_apic.c
Original file line number Diff line number Diff line change
Expand Up @@ -1514,9 +1514,9 @@ static int setup_ioapic_entry(int apic_id, int irq,
memset(&irte, 0, sizeof(irte));

irte.present = 1;
irte.dst_mode = INT_DEST_MODE;
irte.dst_mode = IRQ_DEST_MODE;
irte.trigger_mode = trigger;
irte.dlvry_mode = INT_DELIVERY_MODE;
irte.dlvry_mode = IRQ_DELIVERY_MODE;
irte.vector = vector;
irte.dest_id = IRTE_DEST(destination);

Expand All @@ -1529,8 +1529,8 @@ static int setup_ioapic_entry(int apic_id, int irq,
} else
#endif
{
entry->delivery_mode = INT_DELIVERY_MODE;
entry->dest_mode = INT_DEST_MODE;
entry->delivery_mode = IRQ_DELIVERY_MODE;
entry->dest_mode = IRQ_DEST_MODE;
entry->dest = destination;
}

Expand Down Expand Up @@ -1659,10 +1659,10 @@ static void __init setup_timer_IRQ0_pin(unsigned int apic_id, unsigned int pin,
* We use logical delivery to get the timer IRQ
* to the first CPU.
*/
entry.dest_mode = INT_DEST_MODE;
entry.dest_mode = IRQ_DEST_MODE;
entry.mask = 1; /* mask IRQ now */
entry.dest = cpu_mask_to_apicid(TARGET_CPUS);
entry.delivery_mode = INT_DELIVERY_MODE;
entry.delivery_mode = IRQ_DELIVERY_MODE;
entry.polarity = 0;
entry.trigger = 0;
entry.vector = vector;
Expand Down Expand Up @@ -3279,9 +3279,9 @@ static int msi_compose_msg(struct pci_dev *pdev, unsigned int irq, struct msi_ms
memset (&irte, 0, sizeof(irte));

irte.present = 1;
irte.dst_mode = INT_DEST_MODE;
irte.dst_mode = IRQ_DEST_MODE;
irte.trigger_mode = 0; /* edge */
irte.dlvry_mode = INT_DELIVERY_MODE;
irte.dlvry_mode = IRQ_DELIVERY_MODE;
irte.vector = cfg->vector;
irte.dest_id = IRTE_DEST(dest);

Expand All @@ -3299,18 +3299,18 @@ static int msi_compose_msg(struct pci_dev *pdev, unsigned int irq, struct msi_ms
msg->address_hi = MSI_ADDR_BASE_HI;
msg->address_lo =
MSI_ADDR_BASE_LO |
((INT_DEST_MODE == 0) ?
((IRQ_DEST_MODE == 0) ?
MSI_ADDR_DEST_MODE_PHYSICAL:
MSI_ADDR_DEST_MODE_LOGICAL) |
((INT_DELIVERY_MODE != dest_LowestPrio) ?
((IRQ_DELIVERY_MODE != dest_LowestPrio) ?
MSI_ADDR_REDIRECTION_CPU:
MSI_ADDR_REDIRECTION_LOWPRI) |
MSI_ADDR_DEST_ID(dest);

msg->data =
MSI_DATA_TRIGGER_EDGE |
MSI_DATA_LEVEL_ASSERT |
((INT_DELIVERY_MODE != dest_LowestPrio) ?
((IRQ_DELIVERY_MODE != dest_LowestPrio) ?
MSI_DATA_DELIVERY_FIXED:
MSI_DATA_DELIVERY_LOWPRI) |
MSI_DATA_VECTOR(cfg->vector);
Expand Down Expand Up @@ -3711,11 +3711,11 @@ int arch_setup_ht_irq(unsigned int irq, struct pci_dev *dev)
HT_IRQ_LOW_BASE |
HT_IRQ_LOW_DEST_ID(dest) |
HT_IRQ_LOW_VECTOR(cfg->vector) |
((INT_DEST_MODE == 0) ?
((IRQ_DEST_MODE == 0) ?
HT_IRQ_LOW_DM_PHYSICAL :
HT_IRQ_LOW_DM_LOGICAL) |
HT_IRQ_LOW_RQEOI_EDGE |
((INT_DELIVERY_MODE != dest_LowestPrio) ?
((IRQ_DELIVERY_MODE != dest_LowestPrio) ?
HT_IRQ_LOW_MT_FIXED :
HT_IRQ_LOW_MT_ARBITRATED) |
HT_IRQ_LOW_IRQ_MASKED;
Expand Down Expand Up @@ -3763,8 +3763,8 @@ int arch_enable_uv_irq(char *irq_name, unsigned int irq, int cpu, int mmr_blade,
BUG_ON(sizeof(struct uv_IO_APIC_route_entry) != sizeof(unsigned long));

entry->vector = cfg->vector;
entry->delivery_mode = INT_DELIVERY_MODE;
entry->dest_mode = INT_DEST_MODE;
entry->delivery_mode = IRQ_DELIVERY_MODE;
entry->dest_mode = IRQ_DEST_MODE;
entry->polarity = 0;
entry->trigger = 0;
entry->mask = 0;
Expand Down
4 changes: 2 additions & 2 deletions arch/x86/mach-generic/bigsmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ struct genapic apic_bigsmp = {
.acpi_madt_oem_check = NULL,
.apic_id_registered = bigsmp_apic_id_registered,

.int_delivery_mode = INT_DELIVERY_MODE,
.int_dest_mode = INT_DEST_MODE,
.irq_delivery_mode = IRQ_DELIVERY_MODE,
.irq_dest_mode = IRQ_DEST_MODE,

.target_cpus = target_cpus,
.ESR_DISABLE = esr_disable,
Expand Down
4 changes: 2 additions & 2 deletions arch/x86/mach-generic/default.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ struct genapic apic_default = {
.acpi_madt_oem_check = NULL,
.apic_id_registered = default_apic_id_registered,

.int_delivery_mode = INT_DELIVERY_MODE,
.int_dest_mode = INT_DEST_MODE,
.irq_delivery_mode = IRQ_DELIVERY_MODE,
.irq_dest_mode = IRQ_DEST_MODE,

.target_cpus = target_cpus,
.ESR_DISABLE = esr_disable,
Expand Down
8 changes: 4 additions & 4 deletions arch/x86/mach-generic/es7000.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
void __init es7000_update_genapic_to_cluster(void)
{
apic->target_cpus = target_cpus_cluster;
apic->int_delivery_mode = INT_DELIVERY_MODE_CLUSTER;
apic->int_dest_mode = INT_DEST_MODE_CLUSTER;
apic->irq_delivery_mode = INT_DELIVERY_MODE_CLUSTER;
apic->irq_dest_mode = INT_DEST_MODE_CLUSTER;
apic->no_balance_irq = NO_BALANCE_IRQ_CLUSTER;

apic->init_apic_ldr = init_apic_ldr_cluster;
Expand Down Expand Up @@ -107,8 +107,8 @@ struct genapic apic_es7000 = {
.acpi_madt_oem_check = es7000_acpi_madt_oem_check,
.apic_id_registered = es7000_apic_id_registered,

.int_delivery_mode = INT_DELIVERY_MODE,
.int_dest_mode = INT_DEST_MODE,
.irq_delivery_mode = IRQ_DELIVERY_MODE,
.irq_dest_mode = IRQ_DEST_MODE,

.target_cpus = target_cpus,
.ESR_DISABLE = esr_disable,
Expand Down
4 changes: 2 additions & 2 deletions arch/x86/mach-generic/numaq.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ struct genapic apic_numaq = {
.acpi_madt_oem_check = NULL,
.apic_id_registered = numaq_apic_id_registered,

.int_delivery_mode = INT_DELIVERY_MODE,
.int_dest_mode = INT_DEST_MODE,
.irq_delivery_mode = IRQ_DELIVERY_MODE,
.irq_dest_mode = IRQ_DEST_MODE,

.target_cpus = target_cpus,
.ESR_DISABLE = esr_disable,
Expand Down
4 changes: 2 additions & 2 deletions arch/x86/mach-generic/summit.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ struct genapic apic_summit = {
.acpi_madt_oem_check = summit_acpi_madt_oem_check,
.apic_id_registered = summit_apic_id_registered,

.int_delivery_mode = INT_DELIVERY_MODE,
.int_dest_mode = INT_DEST_MODE,
.irq_delivery_mode = IRQ_DELIVERY_MODE,
.irq_dest_mode = IRQ_DEST_MODE,

.target_cpus = target_cpus,
.ESR_DISABLE = esr_disable,
Expand Down

0 comments on commit f8987a1

Please sign in to comment.