Skip to content

Commit

Permalink
staging/lustre: fix 'program hangs' errors
Browse files Browse the repository at this point in the history
Fix 'program hangs' defects found by Coverity version 6.5.1:
Missing unlock (LOCK)
Returning without unlocking.

Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3054
Lustre-change: http://review.whamcloud.com/5870
Signed-off-by: Sebastien Buisson <sebastien.buisson@bull.net>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Peng Tao <tao.peng@emc.com>
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Sebastien Buisson authored and Greg Kroah-Hartman committed Jul 23, 2013
1 parent 1253b2e commit f8c47be
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/staging/lustre/lnet/selftest/rpc.c
Original file line number Diff line number Diff line change
Expand Up @@ -661,8 +661,10 @@ srpc_finish_service(struct srpc_service *sv)

cfs_percpt_for_each(scd, i, sv->sv_cpt_data) {
spin_lock(&scd->scd_lock);
if (!swi_deschedule_workitem(&scd->scd_buf_wi))
if (!swi_deschedule_workitem(&scd->scd_buf_wi)) {
spin_unlock(&scd->scd_lock);
return 0;
}

if (scd->scd_buf_nposted > 0) {
CDEBUG(D_NET, "waiting for %d posted buffers to unlink",
Expand Down

0 comments on commit f8c47be

Please sign in to comment.