Skip to content

Commit

Permalink
USB: PCI-quirks: Deletion of unnecessary checks before the function c…
Browse files Browse the repository at this point in the history
…all "pci_dev_put"

The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Markus Elfring authored and Greg Kroah-Hartman committed Nov 25, 2014
1 parent bb2d43e commit f910b6c
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions drivers/usb/host/pci-quirks.c
Original file line number Diff line number Diff line change
Expand Up @@ -233,10 +233,8 @@ int usb_amd_find_chipset_info(void)

spin_unlock_irqrestore(&amd_lock, flags);

if (info.nb_dev)
pci_dev_put(info.nb_dev);
if (info.smbus_dev)
pci_dev_put(info.smbus_dev);
pci_dev_put(info.nb_dev);
pci_dev_put(info.smbus_dev);

} else {
/* no race - commit the result */
Expand Down Expand Up @@ -447,10 +445,8 @@ void usb_amd_dev_put(void)

spin_unlock_irqrestore(&amd_lock, flags);

if (nb)
pci_dev_put(nb);
if (smbus)
pci_dev_put(smbus);
pci_dev_put(nb);
pci_dev_put(smbus);
}
EXPORT_SYMBOL_GPL(usb_amd_dev_put);

Expand Down

0 comments on commit f910b6c

Please sign in to comment.