Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 280307
b: refs/heads/master
c: b393421
h: refs/heads/master
i:
  280305: b6de555
  280303: c6edf36
v: v3
  • Loading branch information
Christoph Hellwig authored and Ben Myers committed Dec 8, 2011
1 parent 2974a53 commit f916a34
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 11 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 0244b9603df38bf19155b761689e1a816fc50b0a
refs/heads/master: b39342134a6ec72778ffc2ddbd3c0faa10c64676
1 change: 0 additions & 1 deletion trunk/fs/xfs/xfs_dquot_item.c
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ xfs_qm_dquot_logitem_format(
logvec->i_len = sizeof(xfs_disk_dquot_t);
logvec->i_type = XLOG_REG_TYPE_DQUOT;

ASSERT(2 == lip->li_desc->lid_size);
qlip->qli_format.qlf_size = 2;

}
Expand Down
2 changes: 0 additions & 2 deletions trunk/fs/xfs/xfs_inode_item.c
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,6 @@ xfs_inode_item_format(
* Assert that no attribute-related log flags are set.
*/
if (!XFS_IFORK_Q(ip)) {
ASSERT(nvecs == lip->li_desc->lid_size);
iip->ili_format.ilf_size = nvecs;
ASSERT(!(iip->ili_format.ilf_fields &
(XFS_ILOG_ADATA | XFS_ILOG_ABROOT | XFS_ILOG_AEXT)));
Expand Down Expand Up @@ -521,7 +520,6 @@ xfs_inode_item_format(
break;
}

ASSERT(nvecs == lip->li_desc->lid_size);
iip->ili_format.ilf_size = nvecs;
}

Expand Down
9 changes: 5 additions & 4 deletions trunk/fs/xfs/xfs_log_cil.c
Original file line number Diff line number Diff line change
Expand Up @@ -179,23 +179,24 @@ xlog_cil_prepare_log_vecs(
void *ptr;
int index;
int len = 0;
uint niovecs;

/* Skip items which aren't dirty in this transaction. */
if (!(lidp->lid_flags & XFS_LID_DIRTY))
continue;

/* Skip items that do not have any vectors for writing */
lidp->lid_size = IOP_SIZE(lidp->lid_item);
if (!lidp->lid_size)
niovecs = IOP_SIZE(lidp->lid_item);
if (!niovecs)
continue;

new_lv = kmem_zalloc(sizeof(*new_lv) +
lidp->lid_size * sizeof(struct xfs_log_iovec),
niovecs * sizeof(struct xfs_log_iovec),
KM_SLEEP);

/* The allocated iovec region lies beyond the log vector. */
new_lv->lv_iovecp = (struct xfs_log_iovec *)&new_lv[1];
new_lv->lv_niovecs = lidp->lid_size;
new_lv->lv_niovecs = niovecs;
new_lv->lv_item = lidp->lid_item;

/* build the vector array and calculate it's length */
Expand Down
1 change: 0 additions & 1 deletion trunk/fs/xfs/xfs_trans.c
Original file line number Diff line number Diff line change
Expand Up @@ -1158,7 +1158,6 @@ xfs_trans_add_item(

lidp->lid_item = lip;
lidp->lid_flags = 0;
lidp->lid_size = 0;
list_add_tail(&lidp->lid_trans, &tp->t_items);

lip->li_desc = lidp;
Expand Down
3 changes: 1 addition & 2 deletions trunk/fs/xfs/xfs_trans.h
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,8 @@ typedef struct xfs_trans_header {
*/
struct xfs_log_item_desc {
struct xfs_log_item *lid_item;
ushort lid_size;
unsigned char lid_flags;
struct list_head lid_trans;
unsigned char lid_flags;
};

#define XFS_LID_DIRTY 0x1
Expand Down

0 comments on commit f916a34

Please sign in to comment.