Skip to content

Commit

Permalink
Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-cor…
Browse files Browse the repository at this point in the history
…e-2.6

* git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core-2.6:
  fix setattr error handling in sysfs, configfs
  kobject: free memory if netlink_kernel_create() fails
  lib/kobject_uevent.c: fix CONIG_NET=n warning
  • Loading branch information
Linus Torvalds committed Jun 4, 2010
2 parents bf4282c + 75de46b commit f9196e7
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
9 changes: 4 additions & 5 deletions fs/configfs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,6 @@ int configfs_setattr(struct dentry * dentry, struct iattr * iattr)
if (!sd)
return -EINVAL;

error = simple_setattr(dentry, iattr);
if (error)
return error;

sd_iattr = sd->s_iattr;
if (!sd_iattr) {
/* setting attributes for the first time, allocate now */
Expand All @@ -89,9 +85,12 @@ int configfs_setattr(struct dentry * dentry, struct iattr * iattr)
sd_iattr->ia_atime = sd_iattr->ia_mtime = sd_iattr->ia_ctime = CURRENT_TIME;
sd->s_iattr = sd_iattr;
}

/* attributes were changed atleast once in past */

error = simple_setattr(dentry, iattr);
if (error)
return error;

if (ia_valid & ATTR_UID)
sd_iattr->ia_uid = iattr->ia_uid;
if (ia_valid & ATTR_GID)
Expand Down
6 changes: 4 additions & 2 deletions fs/sysfs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,13 @@ int sysfs_setattr(struct dentry *dentry, struct iattr *iattr)
if (error)
goto out;

error = sysfs_sd_setattr(sd, iattr);
if (error)
goto out;

/* this ignores size changes */
generic_setattr(inode, iattr);

error = sysfs_sd_setattr(sd, iattr);

out:
mutex_unlock(&sysfs_mutex);
return error;
Expand Down
3 changes: 3 additions & 0 deletions lib/kobject_uevent.c
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ int kobject_action_type(const char *buf, size_t count,
return ret;
}

#ifdef CONFIG_NET
static int kobj_bcast_filter(struct sock *dsk, struct sk_buff *skb, void *data)
{
struct kobject *kobj = data;
Expand All @@ -98,6 +99,7 @@ static int kobj_bcast_filter(struct sock *dsk, struct sk_buff *skb, void *data)

return 0;
}
#endif

static int kobj_usermode_filter(struct kobject *kobj)
{
Expand Down Expand Up @@ -378,6 +380,7 @@ static int uevent_net_init(struct net *net)
if (!ue_sk->sk) {
printk(KERN_ERR
"kobject_uevent: unable to create netlink socket!\n");
kfree(ue_sk);
return -ENODEV;
}
mutex_lock(&uevent_sock_mutex);
Expand Down

0 comments on commit f9196e7

Please sign in to comment.