[netdrvr] tehuti: move ioctl perm check closer to function start

Noticed by davem. Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
git-mirror · Apr 25, 2008 · f946dff · f946dff
1 parent d4f73c8
commit f946dff
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/drivers/net/tehuti.c b/drivers/net/tehuti.c
@@ -649,6 +649,9 @@ static int bdx_ioctl_priv(struct net_device *ndev, struct ifreq *ifr, int cmd)
 		DBG("%d 0x%x 0x%x\n", data[0], data[1], data[2]);
 	}
 
+	if (!capable(CAP_NET_ADMIN))
+		return -EPERM;
+
 	switch (data[0]) {
 
 	case BDX_OP_READ:
@@ -664,8 +667,6 @@ static int bdx_ioctl_priv(struct net_device *ndev, struct ifreq *ifr, int cmd)
 		break;
 
 	case BDX_OP_WRITE:
-		if (!capable(CAP_NET_ADMIN))
-			return -EPERM;
 		error = bdx_range_check(priv, data[1]);
 		if (error < 0)
 			return error;