Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 289449
b: refs/heads/master
c: 08a4f6b
h: refs/heads/master
i:
  289447: 8a5f933
v: v3
  • Loading branch information
Alan Stern authored and Greg Kroah-Hartman committed Feb 24, 2012
1 parent 08c6819 commit f94e04f
Show file tree
Hide file tree
Showing 8 changed files with 61 additions and 126 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 765e0ba62613fb90f09c1b5926750df0aa56f349
refs/heads/master: 08a4f6bc2e7046ce50849d7589b7d0763926d808
23 changes: 6 additions & 17 deletions trunk/drivers/usb/serial/aircable.c
Original file line number Diff line number Diff line change
Expand Up @@ -175,15 +175,13 @@ static struct usb_driver aircable_driver = {
.probe = usb_serial_probe,
.disconnect = usb_serial_disconnect,
.id_table = id_table,
.no_dynamic_id = 1,
};

static struct usb_serial_driver aircable_device = {
.driver = {
.owner = THIS_MODULE,
.name = "aircable",
},
.usb_driver = &aircable_driver,
.id_table = id_table,
.num_ports = 1,
.bulk_out_size = HCI_COMPLETE_FRAME,
Expand All @@ -194,27 +192,18 @@ static struct usb_serial_driver aircable_device = {
.unthrottle = usb_serial_generic_unthrottle,
};

static struct usb_serial_driver * const serial_drivers[] = {
&aircable_device, NULL
};

static int __init aircable_init(void)
{
int retval;
retval = usb_serial_register(&aircable_device);
if (retval)
goto failed_serial_register;
retval = usb_register(&aircable_driver);
if (retval)
goto failed_usb_register;
return 0;

failed_usb_register:
usb_serial_deregister(&aircable_device);
failed_serial_register:
return retval;
return usb_serial_register_drivers(&aircable_driver, serial_drivers);
}

static void __exit aircable_exit(void)
{
usb_deregister(&aircable_driver);
usb_serial_deregister(&aircable_device);
usb_serial_deregister_drivers(&aircable_driver, serial_drivers);
}

MODULE_AUTHOR(DRIVER_AUTHOR);
Expand Down
17 changes: 7 additions & 10 deletions trunk/drivers/usb/serial/ark3116.c
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,6 @@ static struct usb_driver ark3116_driver = {
.probe = usb_serial_probe,
.disconnect = usb_serial_disconnect,
.id_table = id_table,
.no_dynamic_id = 1,
};

static struct usb_serial_driver ark3116_device = {
Expand All @@ -728,7 +727,6 @@ static struct usb_serial_driver ark3116_device = {
.name = "ark3116",
},
.id_table = id_table,
.usb_driver = &ark3116_driver,
.num_ports = 1,
.attach = ark3116_attach,
.release = ark3116_release,
Expand All @@ -745,28 +743,27 @@ static struct usb_serial_driver ark3116_device = {
.process_read_urb = ark3116_process_read_urb,
};

static struct usb_serial_driver * const serial_drivers[] = {
&ark3116_device, NULL
};

static int __init ark3116_init(void)
{
int retval;

retval = usb_serial_register(&ark3116_device);
if (retval)
return retval;
retval = usb_register(&ark3116_driver);
retval = usb_serial_register_drivers(&ark3116_driver, serial_drivers);
if (retval == 0) {
printk(KERN_INFO "%s:"
DRIVER_VERSION ":"
DRIVER_DESC "\n",
KBUILD_MODNAME);
} else
usb_serial_deregister(&ark3116_device);
}
return retval;
}

static void __exit ark3116_exit(void)
{
usb_deregister(&ark3116_driver);
usb_serial_deregister(&ark3116_device);
usb_serial_deregister_drivers(&ark3116_driver, serial_drivers);
}

module_init(ark3116_init);
Expand Down
26 changes: 10 additions & 16 deletions trunk/drivers/usb/serial/belkin_sa.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ static struct usb_driver belkin_driver = {
.probe = usb_serial_probe,
.disconnect = usb_serial_disconnect,
.id_table = id_table_combined,
.no_dynamic_id = 1,
};

/* All of the device info needed for the serial converters */
Expand All @@ -88,7 +87,6 @@ static struct usb_serial_driver belkin_device = {
.name = "belkin",
},
.description = "Belkin / Peracom / GoHubs USB Serial Adapter",
.usb_driver = &belkin_driver,
.id_table = id_table_combined,
.num_ports = 1,
.open = belkin_sa_open,
Expand All @@ -103,6 +101,10 @@ static struct usb_serial_driver belkin_device = {
.release = belkin_sa_release,
};

static struct usb_serial_driver * const serial_drivers[] = {
&belkin_device, NULL
};

struct belkin_sa_private {
spinlock_t lock;
unsigned long control_state;
Expand Down Expand Up @@ -526,25 +528,17 @@ static int belkin_sa_tiocmset(struct tty_struct *tty,
static int __init belkin_sa_init(void)
{
int retval;
retval = usb_serial_register(&belkin_device);
if (retval)
goto failed_usb_serial_register;
retval = usb_register(&belkin_driver);
if (retval)
goto failed_usb_register;
printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":"
DRIVER_DESC "\n");
return 0;
failed_usb_register:
usb_serial_deregister(&belkin_device);
failed_usb_serial_register:

retval = usb_serial_register_drivers(&belkin_driver, serial_drivers);
if (retval == 0)
printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":"
DRIVER_DESC "\n");
return retval;
}

static void __exit belkin_sa_exit (void)
{
usb_deregister(&belkin_driver);
usb_serial_deregister(&belkin_device);
usb_serial_deregister_drivers(&belkin_driver, serial_drivers);
}


Expand Down
19 changes: 6 additions & 13 deletions trunk/drivers/usb/serial/ch341.c
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,6 @@ static struct usb_driver ch341_driver = {
.resume = usb_serial_resume,
.reset_resume = ch341_reset_resume,
.id_table = id_table,
.no_dynamic_id = 1,
.supports_autosuspend = 1,
};

Expand All @@ -635,7 +634,6 @@ static struct usb_serial_driver ch341_device = {
.name = "ch341-uart",
},
.id_table = id_table,
.usb_driver = &ch341_driver,
.num_ports = 1,
.open = ch341_open,
.dtr_rts = ch341_dtr_rts,
Expand All @@ -650,23 +648,18 @@ static struct usb_serial_driver ch341_device = {
.attach = ch341_attach,
};

static struct usb_serial_driver * const serial_drivers[] = {
&ch341_device, NULL
};

static int __init ch341_init(void)
{
int retval;

retval = usb_serial_register(&ch341_device);
if (retval)
return retval;
retval = usb_register(&ch341_driver);
if (retval)
usb_serial_deregister(&ch341_device);
return retval;
return usb_serial_register_drivers(&ch341_driver, serial_drivers);
}

static void __exit ch341_exit(void)
{
usb_deregister(&ch341_driver);
usb_serial_deregister(&ch341_device);
usb_serial_deregister_drivers(&ch341_driver, serial_drivers);
}

module_init(ch341_init);
Expand Down
29 changes: 10 additions & 19 deletions trunk/drivers/usb/serial/cp210x.c
Original file line number Diff line number Diff line change
Expand Up @@ -154,15 +154,13 @@ static struct usb_driver cp210x_driver = {
.probe = usb_serial_probe,
.disconnect = usb_serial_disconnect,
.id_table = id_table,
.no_dynamic_id = 1,
};

static struct usb_serial_driver cp210x_device = {
.driver = {
.owner = THIS_MODULE,
.name = "cp210x",
},
.usb_driver = &cp210x_driver,
.id_table = id_table,
.num_ports = 1,
.bulk_in_size = 256,
Expand All @@ -177,6 +175,10 @@ static struct usb_serial_driver cp210x_device = {
.dtr_rts = cp210x_dtr_rts
};

static struct usb_serial_driver * const serial_drivers[] = {
&cp210x_device, NULL
};

/* Config request types */
#define REQTYPE_HOST_TO_DEVICE 0x41
#define REQTYPE_DEVICE_TO_HOST 0xc1
Expand Down Expand Up @@ -852,27 +854,16 @@ static int __init cp210x_init(void)
{
int retval;

retval = usb_serial_register(&cp210x_device);
if (retval)
return retval; /* Failed to register */

retval = usb_register(&cp210x_driver);
if (retval) {
/* Failed to register */
usb_serial_deregister(&cp210x_device);
return retval;
}

/* Success */
printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":"
DRIVER_DESC "\n");
return 0;
retval = usb_serial_register_drivers(&cp210x_driver, serial_drivers);
if (retval == 0)
printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":"
DRIVER_DESC "\n");
return retval;
}

static void __exit cp210x_exit(void)
{
usb_deregister(&cp210x_driver);
usb_serial_deregister(&cp210x_device);
usb_serial_deregister_drivers(&cp210x_driver, serial_drivers);
}

module_init(cp210x_init);
Expand Down
29 changes: 11 additions & 18 deletions trunk/drivers/usb/serial/cyberjack.c
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ static struct usb_driver cyberjack_driver = {
.probe = usb_serial_probe,
.disconnect = usb_serial_disconnect,
.id_table = id_table,
.no_dynamic_id = 1,
};

static struct usb_serial_driver cyberjack_device = {
Expand All @@ -91,7 +90,6 @@ static struct usb_serial_driver cyberjack_device = {
.name = "cyberjack",
},
.description = "Reiner SCT Cyberjack USB card reader",
.usb_driver = &cyberjack_driver,
.id_table = id_table,
.num_ports = 1,
.attach = cyberjack_startup,
Expand All @@ -106,6 +104,10 @@ static struct usb_serial_driver cyberjack_device = {
.write_bulk_callback = cyberjack_write_bulk_callback,
};

static struct usb_serial_driver * const serial_drivers[] = {
&cyberjack_device, NULL
};

struct cyberjack_private {
spinlock_t lock; /* Lock for SMP */
short rdtodo; /* Bytes still to read */
Expand Down Expand Up @@ -476,28 +478,19 @@ static void cyberjack_write_bulk_callback(struct urb *urb)
static int __init cyberjack_init(void)
{
int retval;
retval = usb_serial_register(&cyberjack_device);
if (retval)
goto failed_usb_serial_register;
retval = usb_register(&cyberjack_driver);
if (retval)
goto failed_usb_register;

printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION " "
DRIVER_AUTHOR "\n");
printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_DESC "\n");

return 0;
failed_usb_register:
usb_serial_deregister(&cyberjack_device);
failed_usb_serial_register:
retval = usb_serial_register_drivers(&cyberjack_driver, serial_drivers);
if (retval == 0) {
printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION " "
DRIVER_AUTHOR "\n");
printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_DESC "\n");
}
return retval;
}

static void __exit cyberjack_exit(void)
{
usb_deregister(&cyberjack_driver);
usb_serial_deregister(&cyberjack_device);
usb_serial_deregister_drivers(&cyberjack_driver, serial_drivers);
}

module_init(cyberjack_init);
Expand Down
Loading

0 comments on commit f94e04f

Please sign in to comment.