Skip to content

Commit

Permalink
usb: gadget: dummy_hcd: allow to free requests on disabled endpoints
Browse files Browse the repository at this point in the history
ep->desc is set to NULL on endpoint disable. That means once an endpoint
is disabled it is not possible to free requests. In my target gadget I
first disable endpoints to make sure I have no requests on the fly and
then free frequests. On dummy I am leaking memory here.
Since I can't imagine a reason why it should be a bad thing, lets allow
to free requests on disabled endpoints. On removal of composite the ep0
request is removed so lets allow that here as well.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Felipe Balbi <balbi@ti.com>
  • Loading branch information
Sebastian Andrzej Siewior authored and Felipe Balbi committed May 4, 2012
1 parent 2e87edf commit f99987b
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions drivers/usb/gadget/dummy_hcd.c
Original file line number Diff line number Diff line change
Expand Up @@ -595,14 +595,12 @@ static struct usb_request *dummy_alloc_request(struct usb_ep *_ep,

static void dummy_free_request(struct usb_ep *_ep, struct usb_request *_req)
{
struct dummy_ep *ep;
struct dummy_request *req;

if (!_ep || !_req)
return;
ep = usb_ep_to_dummy_ep(_ep);
if (!ep->desc && _ep->name != ep0name)
if (!_ep || !_req) {
__WARN();
return;
}

req = usb_request_to_dummy_request(_req);
WARN_ON(!list_empty(&req->queue));
Expand Down

0 comments on commit f99987b

Please sign in to comment.