Skip to content

Commit

Permalink
amd-xgbe: Use disable_irq_nosync when in IRQ context
Browse files Browse the repository at this point in the history
The disable_irq_nosync function, not the disable_irq function, must be
used to disable the DMA channel interrupt from within the interrupt
service routine. Change the disable_irq call to disable_irq_nosync.

Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Lendacky, Thomas authored and David S. Miller committed Dec 10, 2014
1 parent 213a992 commit f9c5c62
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/amd/xgbe/xgbe-drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ static irqreturn_t xgbe_dma_isr(int irq, void *data)
*/
if (napi_schedule_prep(&channel->napi)) {
/* Disable Tx and Rx interrupts */
disable_irq(channel->dma_irq);
disable_irq_nosync(channel->dma_irq);

/* Turn on polling */
__napi_schedule(&channel->napi);
Expand Down

0 comments on commit f9c5c62

Please sign in to comment.