Skip to content

Commit

Permalink
[PATCH] slab: remove unused align parameter from alloc_percpu
Browse files Browse the repository at this point in the history
__alloc_percpu and alloc_percpu both take an 'align' argument which is
completely ignored.  snmp6_mib_init() in net/ipv6/af_inet6.c attempts to use
it, but it will be ignored.  Therefore, remove the 'align' argument and fixup
the lone caller.

Signed-off-by: Matthew Dobson <colpatch@us.ibm.com>
Acked-by: Manfred Spraul <manfred@colorfullife.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Pekka Enberg authored and Linus Torvalds committed Jan 9, 2006
1 parent b792de3 commit f9f7500
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
7 changes: 3 additions & 4 deletions include/linux/percpu.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ struct percpu_data {
(__typeof__(ptr))__p->ptrs[(cpu)]; \
})

extern void *__alloc_percpu(size_t size, size_t align);
extern void *__alloc_percpu(size_t size);
extern void free_percpu(const void *);

#else /* CONFIG_SMP */

#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); (ptr); })

static inline void *__alloc_percpu(size_t size, size_t align)
static inline void *__alloc_percpu(size_t size)
{
void *ret = kmalloc(size, GFP_KERNEL);
if (ret)
Expand All @@ -55,7 +55,6 @@ static inline void free_percpu(const void *ptr)
#endif /* CONFIG_SMP */

/* Simple wrapper for the common case: zeros memory. */
#define alloc_percpu(type) \
((type *)(__alloc_percpu(sizeof(type), __alignof__(type))))
#define alloc_percpu(type) ((type *)(__alloc_percpu(sizeof(type))))

#endif /* __LINUX_PERCPU_H */
3 changes: 1 addition & 2 deletions mm/slab.c
Original file line number Diff line number Diff line change
Expand Up @@ -2944,9 +2944,8 @@ EXPORT_SYMBOL(__kmalloc);
* Objects should be dereferenced using the per_cpu_ptr macro only.
*
* @size: how many bytes of memory are required.
* @align: the alignment, which can't be greater than SMP_CACHE_BYTES.
*/
void *__alloc_percpu(size_t size, size_t align)
void *__alloc_percpu(size_t size)
{
int i;
struct percpu_data *pdata = kmalloc(sizeof (*pdata), GFP_KERNEL);
Expand Down
4 changes: 2 additions & 2 deletions net/ipv6/af_inet6.c
Original file line number Diff line number Diff line change
Expand Up @@ -689,11 +689,11 @@ snmp6_mib_init(void *ptr[2], size_t mibsize, size_t mibalign)
if (ptr == NULL)
return -EINVAL;

ptr[0] = __alloc_percpu(mibsize, mibalign);
ptr[0] = __alloc_percpu(mibsize);
if (!ptr[0])
goto err0;

ptr[1] = __alloc_percpu(mibsize, mibalign);
ptr[1] = __alloc_percpu(mibsize);
if (!ptr[1])
goto err1;

Expand Down

0 comments on commit f9f7500

Please sign in to comment.