Skip to content

Commit

Permalink
drm/i915: break intel_infoframe_flags into _enable and _frequency
Browse files Browse the repository at this point in the history
This will allow us to disable an infoframe without changing its
frequency.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Paulo Zanoni authored and Daniel Vetter committed May 8, 2012
1 parent 3e6e639 commit fa193ff
Showing 1 changed file with 26 additions and 6 deletions.
32 changes: 26 additions & 6 deletions drivers/gpu/drm/i915/intel_hdmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -94,16 +94,33 @@ static u32 intel_infoframe_index(struct dip_infoframe *frame)
return flags;
}

static u32 intel_infoframe_flags(struct dip_infoframe *frame)
static u32 intel_infoframe_enable(struct dip_infoframe *frame)
{
u32 flags = 0;

switch (frame->type) {
case DIP_TYPE_AVI:
flags |= VIDEO_DIP_ENABLE_AVI | VIDEO_DIP_FREQ_VSYNC;
flags |= VIDEO_DIP_ENABLE_AVI;
break;
case DIP_TYPE_SPD:
flags |= VIDEO_DIP_ENABLE_SPD | VIDEO_DIP_FREQ_VSYNC;
flags |= VIDEO_DIP_ENABLE_SPD;
break;
default:
DRM_DEBUG_DRIVER("unknown info frame type %d\n", frame->type);
break;
}

return flags;
}

static u32 intel_infoframe_frequency(struct dip_infoframe *frame)
{
u32 flags = 0;

switch (frame->type) {
case DIP_TYPE_AVI:
case DIP_TYPE_SPD:
flags |= VIDEO_DIP_FREQ_VSYNC;
break;
default:
DRM_DEBUG_DRIVER("unknown info frame type %d\n", frame->type);
Expand Down Expand Up @@ -145,7 +162,8 @@ static void i9xx_write_infoframe(struct drm_encoder *encoder,
data++;
}

val |= intel_infoframe_flags(frame);
val |= intel_infoframe_enable(frame);
val |= intel_infoframe_frequency(frame);

I915_WRITE(VIDEO_DIP_CTL, val);
}
Expand Down Expand Up @@ -176,7 +194,8 @@ static void ironlake_write_infoframe(struct drm_encoder *encoder,
data++;
}

val |= intel_infoframe_flags(frame);
val |= intel_infoframe_enable(frame);
val |= intel_infoframe_frequency(frame);

I915_WRITE(reg, val);
}
Expand Down Expand Up @@ -207,7 +226,8 @@ static void vlv_write_infoframe(struct drm_encoder *encoder,
data++;
}

val |= intel_infoframe_flags(frame);
val |= intel_infoframe_enable(frame);
val |= intel_infoframe_frequency(frame);

I915_WRITE(reg, val);
}
Expand Down

0 comments on commit fa193ff

Please sign in to comment.