Skip to content

Commit

Permalink
[PATCH] i386: add missing iounmap in i386 hpet clocksource code
Browse files Browse the repository at this point in the history
ioremap must be balanced by an iounmap and failing to do so can result
in a memory leak.

Tested (compilation only):
- using allmodconfig
- making sure the files are compiling without any warning/error due to
new changes

Signed-off-by: Amol Lad <amol@verismonetworks.com>
Signed-off-by: Andi Kleen <ak@suse.de>
  • Loading branch information
Amol Lad authored and Andi Kleen committed Dec 7, 2006
1 parent c0e84b9 commit fa5cecd
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion arch/i386/kernel/hpet.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ static int __init init_hpet_clocksource(void)
unsigned long hpet_period;
void __iomem* hpet_base;
u64 tmp;
int err;

if (!is_hpet_enabled())
return -ENODEV;
Expand Down Expand Up @@ -61,7 +62,11 @@ static int __init init_hpet_clocksource(void)
do_div(tmp, FSEC_PER_NSEC);
clocksource_hpet.mult = (u32)tmp;

return clocksource_register(&clocksource_hpet);
err = clocksource_register(&clocksource_hpet);
if (err)
iounmap(hpet_base);

return err;
}

module_init(init_hpet_clocksource);

0 comments on commit fa5cecd

Please sign in to comment.