Skip to content

Commit

Permalink
[ICMP]: Fix extra dst release when ip_options_echo fails
Browse files Browse the repository at this point in the history
When two ip_route_output_key lookups in icmp_send were combined I
forgot to change the error path for ip_options_echo to not drop the
dst reference since it now sits before the dst lookup.  To fix it we
simply jump past the ip_rt_put call.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Herbert Xu authored and David S. Miller committed Feb 5, 2006
1 parent 5b7b644 commit fa60cf7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/ipv4/icmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ void icmp_send(struct sk_buff *skb_in, int type, int code, u32 info)
iph->tos;

if (ip_options_echo(&icmp_param.replyopts, skb_in))
goto ende;
goto out_unlock;


/*
Expand Down

0 comments on commit fa60cf7

Please sign in to comment.