Skip to content

Commit

Permalink
V4L/DVB (6784): tda8290: prevent possible memory leak
Browse files Browse the repository at this point in the history
Always call tda829x_release if tda829x_attach fails for a reason
other than failure to allocate memory for private structure.

Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Michael Krufky authored and Mauro Carvalho Chehab committed Jan 25, 2008
1 parent c7919d5 commit fa746ae
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion drivers/media/video/tda8290.c
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,7 @@ int tda829x_attach(struct tuner *t)
}

if (tda829x_find_tuner(fe) < 0)
return -EINVAL;
goto fail;

if (priv->ver & TDA8290) {
tda8290_init_tuner(fe);
Expand All @@ -717,6 +717,11 @@ int tda829x_attach(struct tuner *t)
t->mode = V4L2_TUNER_ANALOG_TV;

return 0;

fail:
tda829x_release(fe);
fe->ops.analog_demod_ops = NULL;
return -EINVAL;
}
EXPORT_SYMBOL_GPL(tda829x_attach);

Expand Down

0 comments on commit fa746ae

Please sign in to comment.