Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 218679
b: refs/heads/master
c: 140ff89
h: refs/heads/master
i:
  218677: 793e951
  218675: a37904d
  218671: 5b11eda
v: v3
  • Loading branch information
Steven Rostedt authored and Steven Rostedt committed Oct 20, 2010
1 parent 771d6b3 commit fa77f0f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 23 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 69d1b839f7eee347e357b3f6cce7f630cc6ff93d
refs/heads/master: 140ff89127c74b1b1c1b0152a36ea3720ccf6bc3
28 changes: 6 additions & 22 deletions trunk/kernel/trace/ring_buffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -2119,6 +2119,7 @@ rb_reserve_next_event(struct ring_buffer *buffer,
u64 ts, delta;
int nr_loops = 0;
int add_timestamp;
u64 diff;

rb_start_commit(cpu_buffer);

Expand Down Expand Up @@ -2155,29 +2156,13 @@ rb_reserve_next_event(struct ring_buffer *buffer,
goto out_fail;

ts = rb_time_stamp(cpu_buffer->buffer);
diff = ts - cpu_buffer->write_stamp;

/*
* Only the first commit can update the timestamp.
* Yes there is a race here. If an interrupt comes in
* just after the conditional and it traces too, then it
* will also check the deltas. More than one timestamp may
* also be made. But only the entry that did the actual
* commit will be something other than zero.
*/
if (likely(cpu_buffer->tail_page == cpu_buffer->commit_page &&
rb_page_write(cpu_buffer->tail_page) ==
rb_commit_index(cpu_buffer))) {
u64 diff;

diff = ts - cpu_buffer->write_stamp;

/* make sure this diff is calculated here */
barrier();

/* Did the write stamp get updated already? */
if (unlikely(ts < cpu_buffer->write_stamp))
goto get_event;
/* make sure this diff is calculated here */
barrier();

/* Did the write stamp get updated already? */
if (likely(ts >= cpu_buffer->write_stamp)) {
delta = diff;
if (unlikely(test_time_stamp(delta))) {
WARN_ONCE(delta > (1ULL << 59),
Expand All @@ -2189,7 +2174,6 @@ rb_reserve_next_event(struct ring_buffer *buffer,
}
}

get_event:
event = __rb_reserve_next(cpu_buffer, length, ts,
delta, add_timestamp);
if (unlikely(PTR_ERR(event) == -EAGAIN))
Expand Down

0 comments on commit fa77f0f

Please sign in to comment.