Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 295215
b: refs/heads/master
c: ca56dc0
h: refs/heads/master
i:
  295213: e027329
  295211: 66feea7
  295207: 8f73eae
  295199: 7d43e21
v: v3
  • Loading branch information
Josh Triplett authored and Linus Torvalds committed Mar 23, 2012
1 parent a9c927b commit fab31e1
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 6712d85852b348d07301c7480f7eb3312d329143
refs/heads/master: ca56dc098caf93b5437cd6c4ee49f02aa18f84d6
15 changes: 15 additions & 0 deletions trunk/scripts/checkpatch.pl
Original file line number Diff line number Diff line change
Expand Up @@ -1772,6 +1772,21 @@ sub process {
"line over 80 characters\n" . $herecurr);
}

# Check for user-visible strings broken across lines, which breaks the ability
# to grep for the string. Limited to strings used as parameters (those
# following an open parenthesis), which almost completely eliminates false
# positives, as well as warning only once per parameter rather than once per
# line of the string. Make an exception when the previous string ends in a
# newline (multiple lines in one string constant) or \n\t (common in inline
# assembly to indent the instruction on the following line).
if ($line =~ /^\+\s*"/ &&
$prevline =~ /"\s*$/ &&
$prevline =~ /\(/ &&
$prevrawline !~ /\\n(?:\\t)*"\s*$/) {
WARN("SPLIT_STRING",
"quoted string split across lines\n" . $hereprev);
}

# check for spaces before a quoted newline
if ($rawline =~ /^.*\".*\s\\n/) {
WARN("QUOTED_WHITESPACE_BEFORE_NEWLINE",
Expand Down

0 comments on commit fab31e1

Please sign in to comment.