Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 75769
b: refs/heads/master
c: 66ac831
h: refs/heads/master
i:
  75767: aeff252
v: v3
  • Loading branch information
Greg Kroah-Hartman committed Jan 25, 2008
1 parent 6c25426 commit fabe721
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 13 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 89a07e34b16d9dcdf0a9ada3ca0c9a506b490c8f
refs/heads/master: 66ac831e03879c3c7dae76f793e6094e407081d2
22 changes: 10 additions & 12 deletions trunk/drivers/firmware/efivars.c
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ static struct attribute_group efi_subsys_attr_group = {
};


static decl_subsys(vars, NULL);
static struct kset *vars_kset;
static struct kset *efi_kset;

/*
Expand Down Expand Up @@ -618,7 +618,7 @@ efivar_create_sysfs_entry(unsigned long variable_name_size,
efi_guid_unparse(vendor_guid, short_name + strlen(short_name));

kobject_set_name(&new_efivar->kobj, "%s", short_name);
new_efivar->kobj.kset = &vars_subsys;
new_efivar->kobj.kset = vars_kset;
new_efivar->kobj.ktype = &efivar_ktype;
i = kobject_register(&new_efivar->kobj);
if (i) {
Expand Down Expand Up @@ -675,12 +675,10 @@ efivars_init(void)
goto out_free;
}

vars_subsys.kobj.kset = efi_kset;

error = subsystem_register(&vars_subsys);

if (error) {
printk(KERN_ERR "efivars: Subsystem registration failed with error %d.\n", error);
vars_kset = kset_create_and_add("vars", NULL, &efi_kset->kobj);
if (!vars_kset) {
printk(KERN_ERR "efivars: Subsystem registration failed.\n");
error = -ENOMEM;
goto out_firmware_unregister;
}

Expand Down Expand Up @@ -715,12 +713,12 @@ efivars_init(void)
* Now add attributes to allow creation of new vars
* and deletion of existing ones...
*/
error = sysfs_create_bin_file(&vars_subsys.kobj,
error = sysfs_create_bin_file(&vars_kset->kobj,
&var_subsys_attr_new_var);
if (error)
printk(KERN_ERR "efivars: unable to create new_var sysfs file"
" due to error %d\n", error);
error = sysfs_create_bin_file(&vars_subsys.kobj,
error = sysfs_create_bin_file(&vars_kset->kobj,
&var_subsys_attr_del_var);
if (error)
printk(KERN_ERR "efivars: unable to create del_var sysfs file"
Expand All @@ -733,7 +731,7 @@ efivars_init(void)
else
goto out_free;

subsystem_unregister(&vars_subsys);
kset_unregister(vars_kset);

out_firmware_unregister:
kset_unregister(efi_kset);
Expand All @@ -756,7 +754,7 @@ efivars_exit(void)
efivar_unregister(entry);
}

subsystem_unregister(&vars_subsys);
kset_unregister(vars_kset);
kset_unregister(efi_kset);
}

Expand Down

0 comments on commit fabe721

Please sign in to comment.