Skip to content

Commit

Permalink
net: use kasprintf() for socket cache names
Browse files Browse the repository at this point in the history
kasprintf() makes code smaller.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Alexey Dobriyan authored and David S. Miller committed Feb 17, 2010
1 parent 8a5ce54 commit faf2342
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions net/core/sock.c
Original file line number Diff line number Diff line change
Expand Up @@ -2228,13 +2228,10 @@ int proto_register(struct proto *prot, int alloc_slab)
}

if (prot->rsk_prot != NULL) {
static const char mask[] = "request_sock_%s";

prot->rsk_prot->slab_name = kmalloc(strlen(prot->name) + sizeof(mask) - 1, GFP_KERNEL);
prot->rsk_prot->slab_name = kasprintf(GFP_KERNEL, "request_sock_%s", prot->name);
if (prot->rsk_prot->slab_name == NULL)
goto out_free_sock_slab;

sprintf(prot->rsk_prot->slab_name, mask, prot->name);
prot->rsk_prot->slab = kmem_cache_create(prot->rsk_prot->slab_name,
prot->rsk_prot->obj_size, 0,
SLAB_HWCACHE_ALIGN, NULL);
Expand All @@ -2247,14 +2244,11 @@ int proto_register(struct proto *prot, int alloc_slab)
}

if (prot->twsk_prot != NULL) {
static const char mask[] = "tw_sock_%s";

prot->twsk_prot->twsk_slab_name = kmalloc(strlen(prot->name) + sizeof(mask) - 1, GFP_KERNEL);
prot->twsk_prot->twsk_slab_name = kasprintf(GFP_KERNEL, "tw_sock_%s", prot->name);

if (prot->twsk_prot->twsk_slab_name == NULL)
goto out_free_request_sock_slab;

sprintf(prot->twsk_prot->twsk_slab_name, mask, prot->name);
prot->twsk_prot->twsk_slab =
kmem_cache_create(prot->twsk_prot->twsk_slab_name,
prot->twsk_prot->twsk_obj_size,
Expand Down

0 comments on commit faf2342

Please sign in to comment.