Skip to content

Commit

Permalink
Input: ucb1400_ts - allow passing IRQ through platfrom_data
Browse files Browse the repository at this point in the history
This patch allows UCB1400 to get IRQ GPIO from platform data. In case
platform_data are not supplied or the IRQ supplied in the platform_data
is negative, fall back to the old IRQ detection algorithm.

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  • Loading branch information
Marek Vasut authored and Dmitry Torokhov committed Nov 20, 2009
1 parent 765af10 commit fb14159
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 4 deletions.
11 changes: 7 additions & 4 deletions drivers/input/touchscreen/ucb1400_ts.c
Original file line number Diff line number Diff line change
Expand Up @@ -355,10 +355,13 @@ static int ucb1400_ts_probe(struct platform_device *dev)
goto err;
}

error = ucb1400_ts_detect_irq(ucb);
if (error) {
printk(KERN_ERR "UCB1400: IRQ probe failed\n");
goto err_free_devs;
/* Only in case the IRQ line wasn't supplied, try detecting it */
if (ucb->irq < 0) {
error = ucb1400_ts_detect_irq(ucb);
if (error) {
printk(KERN_ERR "UCB1400: IRQ probe failed\n");
goto err_free_devs;
}
}

init_waitqueue_head(&ucb->ts_wait);
Expand Down
7 changes: 7 additions & 0 deletions drivers/mfd/ucb1400_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ static int ucb1400_core_probe(struct device *dev)
struct ucb1400_ts ucb_ts;
struct ucb1400_gpio ucb_gpio;
struct snd_ac97 *ac97;
struct ucb1400_pdata *pdata = dev->platform_data;

memset(&ucb_ts, 0, sizeof(ucb_ts));
memset(&ucb_gpio, 0, sizeof(ucb_gpio));
Expand Down Expand Up @@ -88,6 +89,12 @@ static int ucb1400_core_probe(struct device *dev)

/* TOUCHSCREEN */
ucb_ts.ac97 = ac97;

if (pdata != NULL && pdata->irq >= 0)
ucb_ts.irq = pdata->irq;
else
ucb_ts.irq = -1;

ucb->ucb1400_ts = platform_device_alloc("ucb1400_ts", -1);
if (!ucb->ucb1400_ts) {
err = -ENOMEM;
Expand Down
4 changes: 4 additions & 0 deletions include/linux/ucb1400.h
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,10 @@ struct ucb1400 {
struct platform_device *ucb1400_gpio;
};

struct ucb1400_pdata {
int irq;
};

static inline u16 ucb1400_reg_read(struct snd_ac97 *ac97, u16 reg)
{
return ac97->bus->ops->read(ac97, reg);
Expand Down

0 comments on commit fb14159

Please sign in to comment.