Skip to content

Commit

Permalink
of/selftest: add testcase for nodes with same name and address
Browse files Browse the repository at this point in the history
Add a test case for nodes which have the same name and same
non-translatable unit address.

Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Grant Likely <grant.likely@linaro.org>
Reviewed-by: Frank Rowand <frank.rowand@sonymobile.com>
  • Loading branch information
Rob Herring committed May 13, 2014
1 parent 7d1cdc8 commit fb2caa5
Show file tree
Hide file tree
Showing 3 changed files with 55 additions and 1 deletion.
20 changes: 19 additions & 1 deletion drivers/of/selftest.c
Original file line number Diff line number Diff line change
Expand Up @@ -431,8 +431,12 @@ static void __init of_selftest_match_node(void)
static void __init of_selftest_platform_populate(void)
{
int irq;
struct device_node *np;
struct device_node *np, *child;
struct platform_device *pdev;
struct of_device_id match[] = {
{ .compatible = "test-device", },
{}
};

np = of_find_node_by_path("/testcase-data");
of_platform_populate(np, of_default_bus_match_table, NULL, NULL);
Expand All @@ -452,6 +456,20 @@ static void __init of_selftest_platform_populate(void)
irq = platform_get_irq(pdev, 0);
selftest(irq < 0 && irq != -EPROBE_DEFER, "device parsing error failed - %d\n", irq);

np = of_find_node_by_path("/testcase-data/platform-tests");
if (!np) {
pr_err("No testcase data in device tree\n");
return;
}

for_each_child_of_node(np, child) {
struct device_node *grandchild;
of_platform_populate(child, match, NULL, NULL);
for_each_child_of_node(child, grandchild)
selftest(of_find_device_by_node(grandchild),
"Could not create device for node '%s'\n",
grandchild->name);
}
}

static int __init of_selftest(void)
Expand Down
1 change: 1 addition & 0 deletions drivers/of/testcase-data/testcases.dtsi
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#include "tests-phandle.dtsi"
#include "tests-interrupts.dtsi"
#include "tests-match.dtsi"
#include "tests-platform.dtsi"
35 changes: 35 additions & 0 deletions drivers/of/testcase-data/tests-platform.dtsi
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@

/ {
testcase-data {
platform-tests {
#address-cells = <1>;
#size-cells = <0>;

test-device@0 {
compatible = "test-device";
reg = <0x0>;

#address-cells = <1>;
#size-cells = <0>;

dev@100 {
compatible = "test-sub-device";
reg = <0x100>;
};
};

test-device@1 {
compatible = "test-device";
reg = <0x1>;

#address-cells = <1>;
#size-cells = <0>;

dev@100 {
compatible = "test-sub-device";
reg = <0x100>;
};
};
};
};
};

0 comments on commit fb2caa5

Please sign in to comment.