---

yaml --- r: 68068 b: refs/heads/master c: 4f34337 h: refs/heads/master v: v3
git-mirror · Oct 12, 2007 · fb68a4d · fb68a4d
1 parent f3eb027
commit fb68a4d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 50a99018787aa1aed812e09ad5b27647475656a0
+refs/heads/master: 4f34337b1f6f7c1e0f2e3c938eb9eadd340593fe
diff --git a/trunk/drivers/ata/libata-core.c b/trunk/drivers/ata/libata-core.c
@@ -5906,6 +5906,10 @@ int ata_flush_cache(struct ata_device *dev)
 	else
 		cmd = ATA_CMD_FLUSH;
 
+	/* This is wrong. On a failed flush we get back the LBA of the lost
+	   sector and we should (assuming it wasn't aborted as unknown) issue
+	   a further flush command to continue the writeback until it 
+	   does not error */
 	err_mask = ata_do_simple_cmd(dev, cmd);
 	if (err_mask) {
 		ata_dev_printk(dev, KERN_ERR, "failed to flush cache\n");