Skip to content

Commit

Permalink
[ARM] build fixes for netX serial driver
Browse files Browse the repository at this point in the history
Make the netX serial driver tristate (as the help text implied). Make the
serial driver build correctly if the netX serial console is disabled. Do not
allow the netX serial console if the netX serial driver is build as a module.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
  • Loading branch information
Paul Bolle authored and Sascha Hauer committed Oct 30, 2008
1 parent e946217 commit fb881f7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions drivers/serial/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -1276,7 +1276,7 @@ config SERIAL_SGI_IOC3
say Y or M. Otherwise, say N.

config SERIAL_NETX
bool "NetX serial port support"
tristate "NetX serial port support"
depends on ARM && ARCH_NETX
select SERIAL_CORE
help
Expand All @@ -1288,7 +1288,7 @@ config SERIAL_NETX

config SERIAL_NETX_CONSOLE
bool "Console on NetX serial port"
depends on SERIAL_NETX
depends on SERIAL_NETX=y
select SERIAL_CORE_CONSOLE
help
If you have enabled the serial port on the Hilscher NetX SoC
Expand Down
4 changes: 2 additions & 2 deletions drivers/serial/netx-serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@
#define SERIAL_NX_MAJOR 204
#define MINOR_START 170

#ifdef CONFIG_SERIAL_NETX_CONSOLE

enum uart_regs {
UART_DR = 0x00,
UART_SR = 0x04,
Expand Down Expand Up @@ -528,6 +526,8 @@ static struct netx_port netx_ports[] = {
}
};

#ifdef CONFIG_SERIAL_NETX_CONSOLE

static void netx_console_putchar(struct uart_port *port, int ch)
{
while (readl(port->membase + UART_FR) & FR_BUSY);
Expand Down

0 comments on commit fb881f7

Please sign in to comment.