Skip to content

Commit

Permalink
[media] omap3isp: preview: Remove lens shading compensation support
Browse files Browse the repository at this point in the history
The feature isn't fully implemented and doesn't work, remove it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Laurent Pinchart authored and Mauro Carvalho Chehab committed Aug 11, 2012
1 parent b1e71f3 commit fbabfa8
Showing 1 changed file with 1 addition and 17 deletions.
18 changes: 1 addition & 17 deletions drivers/media/video/omap3isp/isppreview.c
Original file line number Diff line number Diff line change
Expand Up @@ -214,22 +214,6 @@ preview_enable_drkframe(struct isp_prev_device *prev, u8 enable)
ISPPRV_PCR_DRKFEN);
}

/*
* preview_config_drkf_shadcomp - Configures shift value in shading comp.
* @scomp_shtval: 3bit value of shift used in shading compensation.
*/
static void
preview_config_drkf_shadcomp(struct isp_prev_device *prev,
const void *scomp_shtval)
{
struct isp_device *isp = to_isp_device(prev);
const u32 *shtval = scomp_shtval;

isp_reg_clr_set(isp, OMAP3_ISP_IOMEM_PREV, ISPPRV_PCR,
ISPPRV_PCR_SCOMP_SFT_MASK,
*shtval << ISPPRV_PCR_SCOMP_SFT_SHIFT);
}

/*
* preview_enable_hmed - Enables/Disables of the Horizontal Median Filter.
* @enable: 1 - Enables Horizontal Median Filter.
Expand Down Expand Up @@ -870,7 +854,7 @@ static const struct preview_update update_attrs[] = {
NULL,
preview_enable_drkframe,
}, /* OMAP3ISP_PREV_LENS_SHADING */ {
preview_config_drkf_shadcomp,
NULL,
preview_enable_drkframe,
}, /* OMAP3ISP_PREV_NF */ {
preview_config_noisefilter,
Expand Down

0 comments on commit fbabfa8

Please sign in to comment.