Skip to content

Commit

Permalink
PCI / PM: Drop CONFIG_PM_RUNTIME from the PCI core
Browse files Browse the repository at this point in the history
After commit b2b49cc (PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is
selected) PM_RUNTIME is always set if PM is set, so quite a few
depend on CONFIG_PM.

Replace CONFIG_PM_RUNTIME with CONFIG_PM in the PCI core code.

Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Kevin Hilman <khilman@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Rafael J. Wysocki committed Dec 3, 2014
1 parent 5de21bb commit fbb988b
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 16 deletions.
20 changes: 7 additions & 13 deletions drivers/pci/pci-driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -1104,7 +1104,7 @@ static int pci_pm_restore(struct device *dev)

#endif /* !CONFIG_HIBERNATE_CALLBACKS */

#ifdef CONFIG_PM_RUNTIME
#ifdef CONFIG_PM

static int pci_pm_runtime_suspend(struct device *dev)
{
Expand Down Expand Up @@ -1200,16 +1200,6 @@ static int pci_pm_runtime_idle(struct device *dev)
return ret;
}

#else /* !CONFIG_PM_RUNTIME */

#define pci_pm_runtime_suspend NULL
#define pci_pm_runtime_resume NULL
#define pci_pm_runtime_idle NULL

#endif /* !CONFIG_PM_RUNTIME */

#ifdef CONFIG_PM

static const struct dev_pm_ops pci_dev_pm_ops = {
.prepare = pci_pm_prepare,
.suspend = pci_pm_suspend,
Expand All @@ -1231,11 +1221,15 @@ static const struct dev_pm_ops pci_dev_pm_ops = {

#define PCI_PM_OPS_PTR (&pci_dev_pm_ops)

#else /* !COMFIG_PM_OPS */
#else /* !CONFIG_PM */

#define pci_pm_runtime_suspend NULL
#define pci_pm_runtime_resume NULL
#define pci_pm_runtime_idle NULL

#define PCI_PM_OPS_PTR NULL

#endif /* !COMFIG_PM_OPS */
#endif /* !CONFIG_PM */

/**
* __pci_register_driver - register a new pci driver
Expand Down
4 changes: 2 additions & 2 deletions drivers/pci/pci-sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ static ssize_t dev_bus_rescan_store(struct device *dev,
}
static DEVICE_ATTR(rescan, (S_IWUSR|S_IWGRP), NULL, dev_bus_rescan_store);

#if defined(CONFIG_PM_RUNTIME) && defined(CONFIG_ACPI)
#if defined(CONFIG_PM) && defined(CONFIG_ACPI)
static ssize_t d3cold_allowed_store(struct device *dev,
struct device_attribute *attr,
const char *buf, size_t count)
Expand Down Expand Up @@ -566,7 +566,7 @@ static struct attribute *pci_dev_attrs[] = {
&dev_attr_enable.attr,
&dev_attr_broken_parity_status.attr,
&dev_attr_msi_bus.attr,
#if defined(CONFIG_PM_RUNTIME) && defined(CONFIG_ACPI)
#if defined(CONFIG_PM) && defined(CONFIG_ACPI)
&dev_attr_d3cold_allowed.attr,
#endif
#ifdef CONFIG_OF
Expand Down
2 changes: 1 addition & 1 deletion drivers/pci/pcie/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -79,4 +79,4 @@ endchoice

config PCIE_PME
def_bool y
depends on PCIEPORTBUS && PM_RUNTIME
depends on PCIEPORTBUS && PM

0 comments on commit fbb988b

Please sign in to comment.