Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 157323
b: refs/heads/master
c: d3c8660
h: refs/heads/master
i:
  157321: b61b5b9
  157319: 7b7eb2b
v: v3
  • Loading branch information
Oleg Nesterov authored and James Morris committed Aug 10, 2009
1 parent a18f7ea commit fbbc119
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 47d439e9fb8a81a90022cfa785bf1c36c4e2aff6
refs/heads/master: d3c8660233d3f2801e14eaf722937ff4ed49bfb7
8 changes: 3 additions & 5 deletions trunk/fs/proc/base.c
Original file line number Diff line number Diff line change
Expand Up @@ -235,20 +235,18 @@ static int check_mem_permission(struct task_struct *task)
struct mm_struct *mm_for_maps(struct task_struct *task)
{
struct mm_struct *mm = get_task_mm(task);
if (!mm)
return NULL;
if (mm != current->mm) {

if (mm && mm != current->mm) {
/*
* task->mm can be changed before security check,
* in that case we must notice the change after.
*/
if (!ptrace_may_access(task, PTRACE_MODE_READ) ||
mm != task->mm) {
mmput(mm);
return NULL;
mm = NULL;
}
}
down_read(&mm->mmap_sem);
return mm;
}

Expand Down
1 change: 1 addition & 0 deletions trunk/fs/proc/task_mmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ static void *m_start(struct seq_file *m, loff_t *pos)
mm = mm_for_maps(priv->task);
if (!mm)
return NULL;
down_read(&mm->mmap_sem);

tail_vma = get_gate_vma(priv->task);
priv->tail_vma = tail_vma;
Expand Down
1 change: 1 addition & 0 deletions trunk/fs/proc/task_nommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ static void *m_start(struct seq_file *m, loff_t *pos)
priv->task = NULL;
return NULL;
}
down_read(&mm->mmap_sem);

/* start from the Nth VMA */
for (p = rb_first(&mm->mm_rb); p; p = rb_next(p))
Expand Down

0 comments on commit fbbc119

Please sign in to comment.