Skip to content

Commit

Permalink
parisc: fix possible memory leak in pat_query_module()
Browse files Browse the repository at this point in the history
pa_pdc_cell has been allocated in this function and so should be
freed before leaving from the error handling cases.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Helge Deller <deller@gmx.de>
  • Loading branch information
Wei Yongjun authored and Helge Deller committed Feb 20, 2013
1 parent ec758f9 commit fbd4843
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions arch/parisc/kernel/inventory.c
Original file line number Diff line number Diff line change
Expand Up @@ -186,12 +186,14 @@ pat_query_module(ulong pcell_loc, ulong mod_index)

if (status != PDC_OK) {
/* no more cell modules or error */
kfree(pa_pdc_cell);
return status;
}

temp = pa_pdc_cell->cba;
dev = alloc_pa_dev(PAT_GET_CBA(temp), &(pa_pdc_cell->mod_path));
if (!dev) {
kfree(pa_pdc_cell);
return PDC_OK;
}

Expand Down

0 comments on commit fbd4843

Please sign in to comment.