Skip to content

Commit

Permalink
hwmon: (fam15h_power) Correct sign extension of running_avg_capture
Browse files Browse the repository at this point in the history
Wrong bit was used for sign extension which caused wrong end results.
Thanks to Andre for spotting this bug.

Reported-by: Andre Przywara <andre.przywara@amd.com>
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: stable@vger.kernel.org
  • Loading branch information
Andreas Herrmann authored and Jean Delvare committed Mar 23, 2012
1 parent 4375382 commit fc0900c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/hwmon/fam15h_power.c
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ static ssize_t show_power(struct device *dev,
pci_bus_read_config_dword(f4->bus, PCI_DEVFN(PCI_SLOT(f4->devfn), 5),
REG_TDP_RUNNING_AVERAGE, &val);
running_avg_capture = (val >> 4) & 0x3fffff;
running_avg_capture = sign_extend32(running_avg_capture, 22);
running_avg_capture = sign_extend32(running_avg_capture, 21);
running_avg_range = val & 0xf;

pci_bus_read_config_dword(f4->bus, PCI_DEVFN(PCI_SLOT(f4->devfn), 5),
Expand Down

0 comments on commit fc0900c

Please sign in to comment.