Skip to content

Commit

Permalink
x86: remove vector_lock around cpu_online_map
Browse files Browse the repository at this point in the history
This lock does not protect cpu_online_map, so its
length can be shortened, and in some cases, removed.

Signed-off-by: Glauber Costa <gcosta@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Glauber Costa authored and Ingo Molnar committed Apr 17, 2008
1 parent 70708a1 commit fc25da9
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions arch/x86/kernel/smpboot_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,9 @@ void __cpuinit start_secondary(void)
/*
* Allow the master to continue.
*/
spin_unlock(&vector_lock);
cpu_set(smp_processor_id(), cpu_online_map);
per_cpu(cpu_state, smp_processor_id()) = CPU_ONLINE;
spin_unlock(&vector_lock);

unlock_ipi_call_lock();

Expand Down Expand Up @@ -879,10 +879,8 @@ int __cpu_disable(void)
local_irq_disable();
remove_siblinginfo(cpu);

spin_lock(&vector_lock);
/* It's now safe to remove this processor from the online map */
cpu_clear(cpu, cpu_online_map);
spin_unlock(&vector_lock);
remove_cpu_from_maps();
fixup_irqs(cpu_online_map);
return 0;
Expand Down

0 comments on commit fc25da9

Please sign in to comment.