Skip to content

Commit

Permalink
Merge branch 'drm-linus' of git://git.kernel.org/pub/scm/linux/kernel…
Browse files Browse the repository at this point in the history
…/git/airlied/drm-2.6

* 'drm-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6:
  drm/radeon: Fix 3 regressions - since buffer rework
  • Loading branch information
Linus Torvalds committed May 11, 2010
2 parents 9fc282b + c9ff04c commit fc2a093
Showing 1 changed file with 10 additions and 9 deletions.
19 changes: 10 additions & 9 deletions drivers/gpu/drm/radeon/radeon_state.c
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ static __inline__ int radeon_check_and_fixup_packet3(drm_radeon_private_t *
if ((*cmd & RADEON_GMC_SRC_PITCH_OFFSET_CNTL) &&
(*cmd & RADEON_GMC_DST_PITCH_OFFSET_CNTL)) {
u32 *cmd3 = drm_buffer_pointer_to_dword(cmdbuf->buffer, 3);
offset = *cmd << 10;
offset = *cmd3 << 10;
if (radeon_check_and_fixup_offset
(dev_priv, file_priv, &offset)) {
DRM_ERROR("Invalid second packet offset\n");
Expand Down Expand Up @@ -2895,18 +2895,20 @@ static int radeon_cp_cmdbuf(struct drm_device *dev, void *data,
return rv;
rv = drm_buffer_copy_from_user(cmdbuf->buffer, buffer,
cmdbuf->bufsz);
if (rv)
if (rv) {
drm_buffer_free(cmdbuf->buffer);
return rv;
}
}
} else
goto done;

orig_nbox = cmdbuf->nbox;

if (dev_priv->microcode_version == UCODE_R300) {
int temp;
temp = r300_do_cp_cmdbuf(dev, file_priv, cmdbuf);

if (cmdbuf->bufsz != 0)
drm_buffer_free(cmdbuf->buffer);
drm_buffer_free(cmdbuf->buffer);

return temp;
}
Expand Down Expand Up @@ -3012,16 +3014,15 @@ static int radeon_cp_cmdbuf(struct drm_device *dev, void *data,
}
}

if (cmdbuf->bufsz != 0)
drm_buffer_free(cmdbuf->buffer);
drm_buffer_free(cmdbuf->buffer);

done:
DRM_DEBUG("DONE\n");
COMMIT_RING();
return 0;

err:
if (cmdbuf->bufsz != 0)
drm_buffer_free(cmdbuf->buffer);
drm_buffer_free(cmdbuf->buffer);
return -EINVAL;
}

Expand Down

0 comments on commit fc2a093

Please sign in to comment.