Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 84557
b: refs/heads/master
c: 27238b2
h: refs/heads/master
i:
  84555: 4871180
v: v3
  • Loading branch information
Alasdair G Kergon committed Feb 8, 2008
1 parent 7b76259 commit fc39db4
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: b9249e556877643b940e4543824a3de5c85bce49
refs/heads/master: 27238b2bea89b1808b570bece6777ab2abc52fe2
15 changes: 9 additions & 6 deletions trunk/drivers/md/dm-ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,7 @@ static int dev_rename(struct dm_ioctl *param, size_t param_size)
int r;
char *new_name = (char *) param + param->data_start;

if (new_name < (char *) param->data ||
if (new_name < param->data ||
invalid_str(new_name, (void *) param + param_size)) {
DMWARN("Invalid new logical volume name supplied.");
return -EINVAL;
Expand All @@ -728,7 +728,7 @@ static int dev_set_geometry(struct dm_ioctl *param, size_t param_size)
if (!md)
return -ENXIO;

if (geostr < (char *) param->data ||
if (geostr < param->data ||
invalid_str(geostr, (void *) param + param_size)) {
DMWARN("Invalid geometry supplied.");
goto out;
Expand Down Expand Up @@ -1397,13 +1397,11 @@ static int validate_params(uint cmd, struct dm_ioctl *param)
return 0;
}

static int ctl_ioctl(struct inode *inode, struct file *file,
uint command, ulong u)
static int ctl_ioctl(uint command, struct dm_ioctl __user *user)
{
int r = 0;
unsigned int cmd;
struct dm_ioctl *param;
struct dm_ioctl __user *user = (struct dm_ioctl __user *) u;
ioctl_fn fn = NULL;
size_t param_size;

Expand Down Expand Up @@ -1471,8 +1469,13 @@ static int ctl_ioctl(struct inode *inode, struct file *file,
return r;
}

static long dm_ctl_ioctl(struct file *file, uint command, ulong u)
{
return (long)ctl_ioctl(command, (struct dm_ioctl __user *)u);
}

static const struct file_operations _ctl_fops = {
.ioctl = ctl_ioctl,
.unlocked_ioctl = dm_ctl_ioctl,
.owner = THIS_MODULE,
};

Expand Down

0 comments on commit fc39db4

Please sign in to comment.