Skip to content

Commit

Permalink
net: 8390: pcnet_cs: Use setup_timer and mod_timer
Browse files Browse the repository at this point in the history
Use timer API functions setup_timer and mod_timer instead
of structure assignments as they are standard way to set
the timer and to update the expire field of an active timer
respectively.

This is done using Coccinelle and semantic patch used for
this is as follows:

// <smpl>
@@
expression x,y,z,a,b;
@@

-init_timer (&x);
+setup_timer (&x, y, z);
+mod_timer (&a, b);
-x.function = y;
-x.data = z;
-x.expires = b;
-add_timer(&a);
// </smpl>

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Vaishali Thakkar authored and David S. Miller committed Mar 1, 2015
1 parent b8b0134 commit fc4ba63
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions drivers/net/ethernet/8390/pcnet_cs.c
Original file line number Diff line number Diff line change
Expand Up @@ -918,11 +918,8 @@ static int pcnet_open(struct net_device *dev)

info->phy_id = info->eth_phy;
info->link_status = 0x00;
init_timer(&info->watchdog);
info->watchdog.function = ei_watchdog;
info->watchdog.data = (u_long)dev;
info->watchdog.expires = jiffies + HZ;
add_timer(&info->watchdog);
setup_timer(&info->watchdog, ei_watchdog, (u_long)dev);
mod_timer(&info->watchdog, jiffies + HZ);

return ei_open(dev);
} /* pcnet_open */
Expand Down

0 comments on commit fc4ba63

Please sign in to comment.