Skip to content

Commit

Permalink
6lowpan: use stack buffer instead of heap
Browse files Browse the repository at this point in the history
head buffer is only temporary available in lowpan_header_create.
So it's not necessary to put it on the heap.

Also fixed a comment codestyle issue.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Alexander Aring authored and David S. Miller committed Feb 6, 2013
1 parent a07fdce commit fc4e98d
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions net/ieee802154/6lowpan.c
Original file line number Diff line number Diff line change
Expand Up @@ -377,17 +377,14 @@ static int lowpan_header_create(struct sk_buff *skb,
struct ipv6hdr *hdr;
const u8 *saddr = _saddr;
const u8 *daddr = _daddr;
u8 *head;
u8 head[100];
struct ieee802154_addr sa, da;

/* TODO:
* if this package isn't ipv6 one, where should it be routed?
*/
if (type != ETH_P_IPV6)
return 0;
/* TODO:
* if this package isn't ipv6 one, where should it be routed?
*/
head = kzalloc(100, GFP_KERNEL);
if (head == NULL)
return -ENOMEM;

hdr = ipv6_hdr(skb);
hc06_ptr = head + 2;
Expand Down Expand Up @@ -561,8 +558,6 @@ static int lowpan_header_create(struct sk_buff *skb,
skb_pull(skb, sizeof(struct ipv6hdr));
memcpy(skb_push(skb, hc06_ptr - head), head, hc06_ptr - head);

kfree(head);

lowpan_raw_dump_table(__func__, "raw skb data dump", skb->data,
skb->len);

Expand Down

0 comments on commit fc4e98d

Please sign in to comment.