Skip to content

Commit

Permalink
[PATCH] Optimize qe_brg struct to use an array
Browse files Browse the repository at this point in the history
The qe_brg structure manually defined each of the 16 BRG registers, which
made any code that used them cumbersome.  This patch replaces the fields
with a single 16-element array.

Signed-off-by: Timur Tabi <timur@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Timur Tabi authored and Paul Mackerras committed Nov 13, 2006
1 parent 0613ffb commit fc9e8b4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 18 deletions.
3 changes: 1 addition & 2 deletions arch/powerpc/sysdev/qe_lib/qe.c
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,7 @@ void qe_setbrg(u32 brg, u32 rate)
u32 divisor, tempval;
int div16 = 0;

bp = &qe_immr->brg.brgc1;
bp += brg;
bp = &qe_immr->brg.brgc[brg];

divisor = (get_brg_clk() / rate);
if (divisor > QE_BRGC_DIVISOR_MAX + 1) {
Expand Down
17 changes: 1 addition & 16 deletions include/asm-powerpc/immap_qe.h
Original file line number Diff line number Diff line change
Expand Up @@ -136,22 +136,7 @@ struct qe_timers {

/* BRG */
struct qe_brg {
__be32 brgc1; /* BRG1 configuration register */
__be32 brgc2; /* BRG2 configuration register */
__be32 brgc3; /* BRG3 configuration register */
__be32 brgc4; /* BRG4 configuration register */
__be32 brgc5; /* BRG5 configuration register */
__be32 brgc6; /* BRG6 configuration register */
__be32 brgc7; /* BRG7 configuration register */
__be32 brgc8; /* BRG8 configuration register */
__be32 brgc9; /* BRG9 configuration register */
__be32 brgc10; /* BRG10 configuration register */
__be32 brgc11; /* BRG11 configuration register */
__be32 brgc12; /* BRG12 configuration register */
__be32 brgc13; /* BRG13 configuration register */
__be32 brgc14; /* BRG14 configuration register */
__be32 brgc15; /* BRG15 configuration register */
__be32 brgc16; /* BRG16 configuration register */
__be32 brgc[16]; /* BRG configuration registers */
u8 res0[0x40];
} __attribute__ ((packed));

Expand Down

0 comments on commit fc9e8b4

Please sign in to comment.