Skip to content

Commit

Permalink
[PATCH] drivers/char/ip2: kill unused code, label
Browse files Browse the repository at this point in the history
Kill warning:

drivers/char/ip2/ip2main.c: In function �ip2_loadmain�:
drivers/char/ip2/ip2main.c:782: warning: label �out_class� defined but not used

This driver's initialization (and cleanup of errors during init) is
extremely convoluted, and could stand to be transformed into the standard
unwinding-goto style of error cleanup.

Signed-off-by: Jeff Garzik <jeff@garzik.org>
Acked-by: Michael H. Warfield <mhw@wittsend.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Jeff Garzik authored and Linus Torvalds committed Oct 3, 2006
1 parent 397f4eb commit fcc7a8c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/char/ip2/ip2main.c
Original file line number Diff line number Diff line change
Expand Up @@ -779,8 +779,6 @@ ip2_loadmain(int *iop, int *irqp, unsigned char *firmware, int firmsize)
ip2trace (ITRC_NO_PORT, ITRC_INIT, ITRC_RETURN, 0 );
goto out;

out_class:
class_destroy(ip2_class);
out_chrdev:
unregister_chrdev(IP2_IPL_MAJOR, "ip2");
out:
Expand Down

0 comments on commit fcc7a8c

Please sign in to comment.