Skip to content

Commit

Permalink
rtnetlink: fix error return code in rtnl_link_fill()
Browse files Browse the repository at this point in the history
Fix to return a negative error code from the error handling case
instead of 0(possible overwrite to 0 by ops->fill_xstats call),
as returned elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Wei Yongjun authored and David S. Miller committed Mar 27, 2013
1 parent 14109a5 commit fcca143
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion net/core/rtnetlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -496,8 +496,10 @@ static int rtnl_link_fill(struct sk_buff *skb, const struct net_device *dev)
}
if (ops->fill_info) {
data = nla_nest_start(skb, IFLA_INFO_DATA);
if (data == NULL)
if (data == NULL) {
err = -EMSGSIZE;
goto err_cancel_link;
}
err = ops->fill_info(skb, dev);
if (err < 0)
goto err_cancel_data;
Expand Down

0 comments on commit fcca143

Please sign in to comment.