Skip to content

Commit

Permalink
appletalk: info leak in ->getname()
Browse files Browse the repository at this point in the history
There is a one byte hole between ->sat_port and ->sat_addr.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dan Carpenter authored and David S. Miller committed Apr 25, 2013
1 parent cd4baaa commit fccc9f1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/appletalk/ddp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1253,7 +1253,7 @@ static int atalk_getname(struct socket *sock, struct sockaddr *uaddr,
goto out;

*uaddr_len = sizeof(struct sockaddr_at);
memset(&sat.sat_zero, 0, sizeof(sat.sat_zero));
memset(&sat, 0, sizeof(sat));

if (peer) {
err = -ENOTCONN;
Expand Down

0 comments on commit fccc9f1

Please sign in to comment.