Skip to content

Commit

Permalink
[media] radio-wl1273: Fix two warnings
Browse files Browse the repository at this point in the history
drivers/media/radio/radio-wl1273.c: In function ‘wl1273_fm_upload_firmware_patch’:
drivers/media/radio/radio-wl1273.c:675:2: warning: ‘n’ may be used uninitialized in this function
drivers/media/radio/radio-wl1273.c:675:2: warning: ‘i’ may be used uninitialized in this function

Those vars are never initialized, and the debug message makes no sense, as it
will show just two random values.

Cc: Matti J. Aaltonen <matti.j.aaltonen@nokia.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Mauro Carvalho Chehab committed Dec 29, 2010
1 parent 9ae2ae3 commit fce50ac
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/media/radio/radio-wl1273.c
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ static int wl1273_fm_upload_firmware_patch(struct wl1273_device *radio)
const char *fw_name = "radio-wl1273-fw.bin";
struct device *dev = radio->dev;
__u8 *ptr;
int i, n, r;
int r;

dev_dbg(dev, "%s:\n", __func__);

Expand All @@ -672,7 +672,6 @@ static int wl1273_fm_upload_firmware_patch(struct wl1273_device *radio)
/* ignore possible error here */
wl1273_fm_write_cmd(core, WL1273_RESET, 0);

dev_dbg(dev, "n: %d, i: %d\n", n, i);
dev_dbg(dev, "%s - download OK, r: %d\n", __func__, r);
out:
release_firmware(fw_p);
Expand Down

0 comments on commit fce50ac

Please sign in to comment.