Skip to content

Commit

Permalink
staging: android: binder: add enum usage in function arguments
Browse files Browse the repository at this point in the history
Declare the binder_deferred_state enum, and use the new enum
for one of the binder_defer_work function arguments. This
should keep the argument within the confines of the enum
instead of the whole int range.

Signed-off-by: Daniel Walker <dwalker@fifo99.com>
Cc: Brian Swetland <swetland@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Daniel Walker authored and Greg Kroah-Hartman committed Sep 15, 2009
1 parent 9980318 commit fd0a2f0
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/staging/android/binder.c
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ struct binder_buffer {
uint8_t data[0];
};

enum {
enum binder_deferred_state {
BINDER_DEFERRED_PUT_FILES = 0x01,
BINDER_DEFERRED_FLUSH = 0x02,
BINDER_DEFERRED_RELEASE = 0x04,
Expand Down Expand Up @@ -326,7 +326,8 @@ struct binder_transaction {
uid_t sender_euid;
};

static void binder_defer_work(struct binder_proc *proc, int defer);
static void
binder_defer_work(struct binder_proc *proc, enum binder_deferred_state defer);

/*
* copied from get_unused_fd_flags
Expand Down Expand Up @@ -3071,7 +3072,8 @@ static void binder_deferred_func(struct work_struct *work)
}
static DECLARE_WORK(binder_deferred_work, binder_deferred_func);

static void binder_defer_work(struct binder_proc *proc, int defer)
static void
binder_defer_work(struct binder_proc *proc, enum binder_deferred_state defer)
{
mutex_lock(&binder_deferred_lock);
proc->deferred_work |= defer;
Expand Down

0 comments on commit fd0a2f0

Please sign in to comment.