Skip to content

Commit

Permalink
sunhme: Remove stop/wake TX queue calls in set-multicast-list handler.
Browse files Browse the repository at this point in the history
Based upon a bug report by Alexander Beregalov and commentary
from Ben Hutchings.

These are totally unnecessary, in particular because this
driver's ->hard_start_xmit() handler takes the same driver
spinlock that the set-multicast-list handler uses.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Jul 21, 2008
1 parent ebbdbd7 commit fd24c4a
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/net/sunhme.c
Original file line number Diff line number Diff line change
Expand Up @@ -2377,8 +2377,6 @@ static void happy_meal_set_multicast(struct net_device *dev)

spin_lock_irq(&hp->happy_lock);

netif_stop_queue(dev);

if ((dev->flags & IFF_ALLMULTI) || (dev->mc_count > 64)) {
hme_write32(hp, bregs + BMAC_HTABLE0, 0xffff);
hme_write32(hp, bregs + BMAC_HTABLE1, 0xffff);
Expand Down Expand Up @@ -2410,8 +2408,6 @@ static void happy_meal_set_multicast(struct net_device *dev)
hme_write32(hp, bregs + BMAC_HTABLE3, hash_table[3]);
}

netif_wake_queue(dev);

spin_unlock_irq(&hp->happy_lock);
}

Expand Down

0 comments on commit fd24c4a

Please sign in to comment.