Skip to content

Commit

Permalink
x86: signal_64.c: get_stack() doesn't need entire regs
Browse files Browse the repository at this point in the history
Impact: cleanup

get_stack() uses sp only, entire regs is not needed.

Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Hiroshi Shimamoto authored and Ingo Molnar committed Oct 27, 2008
1 parent 709110b commit fd4a203
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions arch/x86/kernel/signal_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -199,12 +199,10 @@ setup_sigcontext(struct sigcontext __user *sc, struct pt_regs *regs,
*/

static void __user *
get_stack(struct k_sigaction *ka, struct pt_regs *regs, unsigned long size)
get_stack(struct k_sigaction *ka, unsigned long sp, unsigned long size)
{
unsigned long sp;

/* Default to using normal stack - redzone*/
sp = regs->sp - 128;
sp -= 128;

/* This is the X/Open sanctioned signal stack switching. */
if (ka->sa.sa_flags & SA_ONSTACK) {
Expand All @@ -224,14 +222,14 @@ static int __setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
struct task_struct *me = current;

if (used_math()) {
fp = get_stack(ka, regs, sig_xstate_size);
fp = get_stack(ka, regs->sp, sig_xstate_size);
frame = (void __user *)round_down(
(unsigned long)fp - sizeof(struct rt_sigframe), 16) - 8;

if (save_i387_xstate(fp) < 0)
return -EFAULT;
} else
frame = get_stack(ka, regs, sizeof(struct rt_sigframe)) - 8;
frame = get_stack(ka, regs->sp, sizeof(struct rt_sigframe)) - 8;

if (!access_ok(VERIFY_WRITE, frame, sizeof(*frame)))
return -EFAULT;
Expand Down

0 comments on commit fd4a203

Please sign in to comment.