Skip to content

Commit

Permalink
Fix a const pointer usage warning in the Digigram miXart soundcard dr…
Browse files Browse the repository at this point in the history
…iver

Fix a const pointer usage warning in the Digigram miXart soundcard driver.  A
const pointer is being passed to copy_from_user() to load the firmware into.
This is okay in this case because the function has allocated the firmware
struct itself, but the const qualifier is part of the firmware struct - so the
patch casts the const away.

Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
  • Loading branch information
David Howells authored and David Woodhouse committed Jul 10, 2008
1 parent 67852dc commit fd4f80d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/pci/mixart/mixart_hwdep.c
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ static int mixart_hwdep_dsp_load(struct snd_hwdep *hw,
(int)dsp->length);
return -ENOMEM;
}
if (copy_from_user(fw.data, dsp->image, dsp->length)) {
if (copy_from_user((void *) fw.data, dsp->image, dsp->length)) {
vfree(fw.data);
return -EFAULT;
}
Expand Down

0 comments on commit fd4f80d

Please sign in to comment.