Skip to content

Commit

Permalink
carl9170: use ieee80211_free_txskb
Browse files Browse the repository at this point in the history
In the past, it was fine to simply call
dev_kfree_skb when it was impossible to
transmit a skb. However, with the new
tx status API:
"mac80211: implement wifi TX status"
Every loose skb needs to be handed back
to mac80211.

Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Christian Lamparter authored and John W. Linville committed Nov 21, 2011
1 parent c3745b4 commit fd67a72
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/wireless/ath/carl9170/tx.c
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ static void carl9170_tx_release(struct kref *ref)
* feedback either [CTL_REQ_TX_STATUS not set]
*/

dev_kfree_skb_any(skb);
ieee80211_free_txskb(ar->hw, skb);
return;
} else {
/*
Expand Down Expand Up @@ -1432,7 +1432,7 @@ void carl9170_op_tx(struct ieee80211_hw *hw, struct sk_buff *skb)

err_free:
ar->tx_dropped++;
dev_kfree_skb_any(skb);
ieee80211_free_txskb(ar->hw, skb);
}

void carl9170_tx_scheduler(struct ar9170 *ar)
Expand Down

0 comments on commit fd67a72

Please sign in to comment.