Skip to content

Commit

Permalink
irda: prevent integer underflow in IRLMP_ENUMDEVICES
Browse files Browse the repository at this point in the history
If the user-provided len is less than the expected offset, the
IRLMP_ENUMDEVICES getsockopt will do a copy_to_user() with a very large
size value.  While this isn't be a security issue on x86 because it will
get caught by the access_ok() check, it may leak large amounts of kernel
heap on other architectures.  In any event, this patch fixes it.

Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dan Rosenberg authored and David S. Miller committed Dec 23, 2010
1 parent 1bde5ac commit fdac1e0
Showing 1 changed file with 11 additions and 7 deletions.
18 changes: 11 additions & 7 deletions net/irda/af_irda.c
Original file line number Diff line number Diff line change
Expand Up @@ -2281,6 +2281,16 @@ static int irda_getsockopt(struct socket *sock, int level, int optname,

switch (optname) {
case IRLMP_ENUMDEVICES:

/* Offset to first device entry */
offset = sizeof(struct irda_device_list) -
sizeof(struct irda_device_info);

if (len < offset) {
err = -EINVAL;
goto out;
}

/* Ask lmp for the current discovery log */
discoveries = irlmp_get_discoveries(&list.len, self->mask.word,
self->nslots);
Expand All @@ -2291,15 +2301,9 @@ static int irda_getsockopt(struct socket *sock, int level, int optname,
}

/* Write total list length back to client */
if (copy_to_user(optval, &list,
sizeof(struct irda_device_list) -
sizeof(struct irda_device_info)))
if (copy_to_user(optval, &list, offset))
err = -EFAULT;

/* Offset to first device entry */
offset = sizeof(struct irda_device_list) -
sizeof(struct irda_device_info);

/* Copy the list itself - watch for overflow */
if (list.len > 2048) {
err = -EINVAL;
Expand Down

0 comments on commit fdac1e0

Please sign in to comment.