Skip to content

Commit

Permalink
[SUNSU]: Fix bogus locking in sunsu_change_mouse_baud()
Browse files Browse the repository at this point in the history
The lock is not held when calling this function, so we
shouldn't drop then reacquire it.

Based upon a report from Jim MacBaine.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Oct 4, 2005
1 parent 3115624 commit fdc657c
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/serial/sunsu.c
Original file line number Diff line number Diff line change
Expand Up @@ -518,11 +518,7 @@ static void sunsu_change_mouse_baud(struct uart_sunsu_port *up)

quot = up->port.uartclk / (16 * new_baud);

spin_unlock(&up->port.lock);

sunsu_change_speed(&up->port, up->cflag, 0, quot);

spin_lock(&up->port.lock);
}

static void receive_kbd_ms_chars(struct uart_sunsu_port *up, struct pt_regs *regs, int is_break)
Expand Down

0 comments on commit fdc657c

Please sign in to comment.