Skip to content

Commit

Permalink
imx: exit functions can/should be void
Browse files Browse the repository at this point in the history
Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
  • Loading branch information
Holger Schurig authored and Sascha Hauer committed May 7, 2009
1 parent 1341d34 commit fde3647
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 25 deletions.
18 changes: 6 additions & 12 deletions arch/arm/mach-mx2/mx27ads.c
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,10 @@ static int uart_mxc_port0_init(struct platform_device *pdev)
ARRAY_SIZE(mxc_uart0_pins), "UART0");
}

static int uart_mxc_port0_exit(struct platform_device *pdev)
static void uart_mxc_port0_exit(struct platform_device *pdev)
{
mxc_gpio_release_multiple_pins(mxc_uart0_pins,
ARRAY_SIZE(mxc_uart0_pins));
return 0;
}

static int mxc_uart1_pins[] = {
Expand All @@ -91,11 +90,10 @@ static int uart_mxc_port1_init(struct platform_device *pdev)
ARRAY_SIZE(mxc_uart1_pins), "UART1");
}

static int uart_mxc_port1_exit(struct platform_device *pdev)
static void uart_mxc_port1_exit(struct platform_device *pdev)
{
mxc_gpio_release_multiple_pins(mxc_uart1_pins,
ARRAY_SIZE(mxc_uart1_pins));
return 0;
}

static int mxc_uart2_pins[] = {
Expand All @@ -111,11 +109,10 @@ static int uart_mxc_port2_init(struct platform_device *pdev)
ARRAY_SIZE(mxc_uart2_pins), "UART2");
}

static int uart_mxc_port2_exit(struct platform_device *pdev)
static void uart_mxc_port2_exit(struct platform_device *pdev)
{
mxc_gpio_release_multiple_pins(mxc_uart2_pins,
ARRAY_SIZE(mxc_uart2_pins));
return 0;
}

static int mxc_uart3_pins[] = {
Expand All @@ -131,11 +128,10 @@ static int uart_mxc_port3_init(struct platform_device *pdev)
ARRAY_SIZE(mxc_uart3_pins), "UART3");
}

static int uart_mxc_port3_exit(struct platform_device *pdev)
static void uart_mxc_port3_exit(struct platform_device *pdev)
{
mxc_gpio_release_multiple_pins(mxc_uart3_pins,
ARRAY_SIZE(mxc_uart3_pins));
return 0;
}

static int mxc_uart4_pins[] = {
Expand All @@ -151,11 +147,10 @@ static int uart_mxc_port4_init(struct platform_device *pdev)
ARRAY_SIZE(mxc_uart4_pins), "UART4");
}

static int uart_mxc_port4_exit(struct platform_device *pdev)
static void uart_mxc_port4_exit(struct platform_device *pdev)
{
mxc_gpio_release_multiple_pins(mxc_uart4_pins,
ARRAY_SIZE(mxc_uart4_pins));
return 0;
}

static int mxc_uart5_pins[] = {
Expand All @@ -171,11 +166,10 @@ static int uart_mxc_port5_init(struct platform_device *pdev)
ARRAY_SIZE(mxc_uart5_pins), "UART5");
}

static int uart_mxc_port5_exit(struct platform_device *pdev)
static void uart_mxc_port5_exit(struct platform_device *pdev)
{
mxc_gpio_release_multiple_pins(mxc_uart5_pins,
ARRAY_SIZE(mxc_uart5_pins));
return 0;
}

static struct platform_device *platform_devices[] __initdata = {
Expand Down
9 changes: 3 additions & 6 deletions arch/arm/mach-mx2/pcm038.c
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,10 @@ static int uart_mxc_port0_init(struct platform_device *pdev)
ARRAY_SIZE(mxc_uart0_pins), "UART0");
}

static int uart_mxc_port0_exit(struct platform_device *pdev)
static void uart_mxc_port0_exit(struct platform_device *pdev)
{
mxc_gpio_release_multiple_pins(mxc_uart0_pins,
ARRAY_SIZE(mxc_uart0_pins));
return 0;
}

static int mxc_uart1_pins[] = {
Expand All @@ -121,11 +120,10 @@ static int uart_mxc_port1_init(struct platform_device *pdev)
ARRAY_SIZE(mxc_uart1_pins), "UART1");
}

static int uart_mxc_port1_exit(struct platform_device *pdev)
static void uart_mxc_port1_exit(struct platform_device *pdev)
{
mxc_gpio_release_multiple_pins(mxc_uart1_pins,
ARRAY_SIZE(mxc_uart1_pins));
return 0;
}

static int mxc_uart2_pins[] = { PE8_PF_UART3_TXD,
Expand All @@ -139,11 +137,10 @@ static int uart_mxc_port2_init(struct platform_device *pdev)
ARRAY_SIZE(mxc_uart2_pins), "UART2");
}

static int uart_mxc_port2_exit(struct platform_device *pdev)
static void uart_mxc_port2_exit(struct platform_device *pdev)
{
mxc_gpio_release_multiple_pins(mxc_uart2_pins,
ARRAY_SIZE(mxc_uart2_pins));
return 0;
}

static struct imxuart_platform_data uart_pdata[] = {
Expand Down
4 changes: 1 addition & 3 deletions arch/arm/mach-mx2/pcm970-baseboard.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,9 @@ static int pcm038_fb_init(struct platform_device *pdev)
ARRAY_SIZE(mxc_fb_pins), "FB");
}

static int pcm038_fb_exit(struct platform_device *pdev)
static void pcm038_fb_exit(struct platform_device *pdev)
{
mxc_gpio_release_multiple_pins(mxc_fb_pins, ARRAY_SIZE(mxc_fb_pins));

return 0;
}

/*
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/plat-mxc/include/mach/imx-uart.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

struct imxuart_platform_data {
int (*init)(struct platform_device *pdev);
int (*exit)(struct platform_device *pdev);
void (*exit)(struct platform_device *pdev);
unsigned int flags;
};

Expand Down
4 changes: 2 additions & 2 deletions arch/arm/plat-mxc/include/mach/imxfb.h
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ struct imx_fb_platform_data {
u_char * fixed_screen_cpu;
dma_addr_t fixed_screen_dma;

int (*init)(struct platform_device*);
int (*exit)(struct platform_device*);
int (*init)(struct platform_device *);
void (*exit)(struct platform_device *);

void (*lcd_power)(int);
void (*backlight_power)(int);
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/plat-mxc/include/mach/usb.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

struct imxusb_platform_data {
int (*init)(struct device *);
int (*exit)(struct device *);
void (*exit)(struct device *);
};

#endif /* __ASM_ARCH_MXC_USB */

0 comments on commit fde3647

Please sign in to comment.