Skip to content

Commit

Permalink
[SCSI] libsas: kill spurious sas_put_device
Browse files Browse the repository at this point in the history
Holdover from a patch rework, prior to the addition of SAS_DEV_DESTROY
we were holding a reference while the destruct was pending in case the
domain was torn down before the desctruct event ran.  That case is
covered by SAS_DEV_DESTROY, and the sas_put_device() just corrupts freed
memory, or worse frees the memory while another agent holds a reference.

Signed-off-by: Maciej Trela <maciej.trela@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
  • Loading branch information
Maciej Trela authored and James Bottomley committed Feb 29, 2012
1 parent 5d7f6d1 commit fdfd9d1
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/scsi/libsas/sas_discover.c
Original file line number Diff line number Diff line change
Expand Up @@ -281,8 +281,6 @@ static void sas_destruct_devices(struct work_struct *work)
sas_rphy_delete(dev->rphy);
dev->rphy = NULL;
sas_unregister_common_dev(port, dev);

sas_put_device(dev);
}
}

Expand Down

0 comments on commit fdfd9d1

Please sign in to comment.