Skip to content

Commit

Permalink
Merge branch 'acpi-driver-core' into device-properties
Browse files Browse the repository at this point in the history
  • Loading branch information
Rafael J. Wysocki committed Mar 25, 2015
2 parents f42712a + ca5b74d commit fe0a20a
Show file tree
Hide file tree
Showing 15 changed files with 59 additions and 36 deletions.
2 changes: 1 addition & 1 deletion drivers/acpi/acpi_platform.c
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev)
pdevinfo.id = -1;
pdevinfo.res = resources;
pdevinfo.num_res = count;
pdevinfo.acpi_node.companion = adev;
pdevinfo.fwnode = acpi_fwnode_handle(adev);
pdevinfo.dma_mask = DMA_BIT_MASK(32);
pdev = platform_device_register_full(&pdevinfo);
if (IS_ERR(pdev))
Expand Down
2 changes: 1 addition & 1 deletion drivers/acpi/dock.c
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ void acpi_dock_add(struct acpi_device *adev)
memset(&pdevinfo, 0, sizeof(pdevinfo));
pdevinfo.name = "dock";
pdevinfo.id = dock_station_count;
pdevinfo.acpi_node.companion = adev;
pdevinfo.fwnode = acpi_fwnode_handle(adev);
pdevinfo.data = &ds;
pdevinfo.size_data = sizeof(ds);
dd = platform_device_register_full(&pdevinfo);
Expand Down
4 changes: 2 additions & 2 deletions drivers/acpi/glue.c
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ int acpi_bind_one(struct device *dev, struct acpi_device *acpi_dev)
unsigned int node_id;
int retval = -EINVAL;

if (ACPI_COMPANION(dev)) {
if (has_acpi_companion(dev)) {
if (acpi_dev) {
dev_warn(dev, "ACPI companion already set\n");
return -EINVAL;
Expand Down Expand Up @@ -220,7 +220,7 @@ int acpi_bind_one(struct device *dev, struct acpi_device *acpi_dev)
list_add(&physical_node->node, physnode_list);
acpi_dev->physical_node_count++;

if (!ACPI_COMPANION(dev))
if (!has_acpi_companion(dev))
ACPI_COMPANION_SET(dev, acpi_dev);

acpi_physnode_link_name(physical_node_name, node_id);
Expand Down
2 changes: 1 addition & 1 deletion drivers/base/platform.c
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ struct platform_device *platform_device_register_full(
goto err_alloc;

pdev->dev.parent = pdevinfo->parent;
ACPI_COMPANION_SET(&pdev->dev, pdevinfo->acpi_node.companion);
pdev->dev.fwnode = pdevinfo->fwnode;

if (pdevinfo->dma_mask) {
/*
Expand Down
2 changes: 2 additions & 0 deletions drivers/gpio/gpiolib.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

enum of_gpio_flags;

struct acpi_device;

/**
* struct acpi_gpio_info - ACPI GPIO specific information
* @gpioint: if %true this GPIO is of type GpioInt otherwise type is GpioIo
Expand Down
4 changes: 2 additions & 2 deletions drivers/i2c/busses/i2c-designware-platdrv.c
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ static int dw_i2c_probe(struct platform_device *pdev)
/* fast mode by default because of legacy reasons */
clk_freq = 400000;

if (ACPI_COMPANION(&pdev->dev)) {
if (has_acpi_companion(&pdev->dev)) {
dw_i2c_acpi_configure(pdev);
} else if (pdev->dev.of_node) {
of_property_read_u32(pdev->dev.of_node,
Expand Down Expand Up @@ -286,7 +286,7 @@ static int dw_i2c_remove(struct platform_device *pdev)
pm_runtime_put(&pdev->dev);
pm_runtime_disable(&pdev->dev);

if (ACPI_COMPANION(&pdev->dev))
if (has_acpi_companion(&pdev->dev))
dw_i2c_acpi_unconfigure(pdev);

return 0;
Expand Down
4 changes: 2 additions & 2 deletions drivers/i2c/i2c-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ static acpi_status acpi_i2c_add_device(acpi_handle handle, u32 level,
return AE_OK;

memset(&info, 0, sizeof(info));
info.acpi_node.companion = adev;
info.fwnode = acpi_fwnode_handle(adev);
info.irq = -1;

INIT_LIST_HEAD(&resource_list);
Expand Down Expand Up @@ -971,7 +971,7 @@ i2c_new_device(struct i2c_adapter *adap, struct i2c_board_info const *info)
client->dev.bus = &i2c_bus_type;
client->dev.type = &i2c_client_type;
client->dev.of_node = info->of_node;
ACPI_COMPANION_SET(&client->dev, info->acpi_node.companion);
client->dev.fwnode = info->fwnode;

i2c_dev_set_name(adap, client);
status = device_register(&client->dev);
Expand Down
2 changes: 1 addition & 1 deletion drivers/iommu/intel-iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,7 @@ static struct intel_iommu *device_to_iommu(struct device *dev, u8 *bus, u8 *devf
if (dev_is_pci(dev)) {
pdev = to_pci_dev(dev);
segment = pci_domain_nr(pdev->bus);
} else if (ACPI_COMPANION(dev))
} else if (has_acpi_companion(dev))
dev = &ACPI_COMPANION(dev)->dev;

rcu_read_lock();
Expand Down
3 changes: 2 additions & 1 deletion include/acpi/acpi_bus.h
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,8 @@ static inline bool is_acpi_node(struct fwnode_handle *fwnode)

static inline struct acpi_device *acpi_node(struct fwnode_handle *fwnode)
{
return fwnode ? container_of(fwnode, struct acpi_device, fwnode) : NULL;
return is_acpi_node(fwnode) ?
container_of(fwnode, struct acpi_device, fwnode) : NULL;
}

static inline struct fwnode_handle *acpi_fwnode_handle(struct acpi_device *adev)
Expand Down
15 changes: 13 additions & 2 deletions include/linux/acpi.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,16 @@ static inline acpi_handle acpi_device_handle(struct acpi_device *adev)
return adev ? adev->handle : NULL;
}

#define ACPI_COMPANION(dev) ((dev)->acpi_node.companion)
#define ACPI_COMPANION_SET(dev, adev) ACPI_COMPANION(dev) = (adev)
#define ACPI_COMPANION(dev) acpi_node((dev)->fwnode)
#define ACPI_COMPANION_SET(dev, adev) (dev)->fwnode = (adev) ? \
acpi_fwnode_handle(adev) : NULL
#define ACPI_HANDLE(dev) acpi_device_handle(ACPI_COMPANION(dev))

static inline bool has_acpi_companion(struct device *dev)
{
return is_acpi_node(dev->fwnode);
}

static inline void acpi_preset_companion(struct device *dev,
struct acpi_device *parent, u64 addr)
{
Expand Down Expand Up @@ -471,6 +477,11 @@ static inline struct fwnode_handle *acpi_fwnode_handle(struct acpi_device *adev)
return NULL;
}

static inline bool has_acpi_companion(struct device *dev)
{
return false;
}

static inline const char *acpi_dev_name(struct acpi_device *adev)
{
return NULL;
Expand Down
13 changes: 3 additions & 10 deletions include/linux/device.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ struct class;
struct subsys_private;
struct bus_type;
struct device_node;
struct fwnode_handle;
struct iommu_ops;
struct iommu_group;

Expand Down Expand Up @@ -650,14 +651,6 @@ struct device_dma_parameters {
unsigned long segment_boundary_mask;
};

struct acpi_device;

struct acpi_dev_node {
#ifdef CONFIG_ACPI
struct acpi_device *companion;
#endif
};

/**
* struct device - The basic device structure
* @parent: The device's "parent" device, the device to which it is attached.
Expand Down Expand Up @@ -703,7 +696,7 @@ struct acpi_dev_node {
* @cma_area: Contiguous memory area for dma allocations
* @archdata: For arch-specific additions.
* @of_node: Associated device tree node.
* @acpi_node: Associated ACPI device node.
* @fwnode: Associated device node supplied by platform firmware.
* @devt: For creating the sysfs "dev".
* @id: device instance
* @devres_lock: Spinlock to protect the resource of the device.
Expand Down Expand Up @@ -779,7 +772,7 @@ struct device {
struct dev_archdata archdata;

struct device_node *of_node; /* associated device tree node */
struct acpi_dev_node acpi_node; /* associated ACPI device node */
struct fwnode_handle *fwnode; /* firmware device node */

dev_t devt; /* dev_t, creates the sysfs "dev" */
u32 id; /* device instance */
Expand Down
25 changes: 25 additions & 0 deletions include/linux/fwnode.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/*
* fwnode.h - Firmware device node object handle type definition.
*
* Copyright (C) 2015, Intel Corporation
* Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation.
*/

#ifndef _LINUX_FWNODE_H_
#define _LINUX_FWNODE_H_

enum fwnode_type {
FWNODE_INVALID = 0,
FWNODE_OF,
FWNODE_ACPI,
};

struct fwnode_handle {
enum fwnode_type type;
};

#endif
4 changes: 2 additions & 2 deletions include/linux/i2c.h
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ static inline int i2c_slave_event(struct i2c_client *client,
* @platform_data: stored in i2c_client.dev.platform_data
* @archdata: copied into i2c_client.dev.archdata
* @of_node: pointer to OpenFirmware device node
* @acpi_node: ACPI device node
* @fwnode: device node supplied by the platform firmware
* @irq: stored in i2c_client.irq
*
* I2C doesn't actually support hardware probing, although controllers and
Expand All @@ -299,7 +299,7 @@ struct i2c_board_info {
void *platform_data;
struct dev_archdata *archdata;
struct device_node *of_node;
struct acpi_dev_node acpi_node;
struct fwnode_handle *fwnode;
int irq;
};

Expand Down
2 changes: 1 addition & 1 deletion include/linux/platform_device.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ extern int platform_add_devices(struct platform_device **, int);

struct platform_device_info {
struct device *parent;
struct acpi_dev_node acpi_node;
struct fwnode_handle *fwnode;

const char *name;
int id;
Expand Down
11 changes: 1 addition & 10 deletions include/linux/property.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#ifndef _LINUX_PROPERTY_H_
#define _LINUX_PROPERTY_H_

#include <linux/fwnode.h>
#include <linux/types.h>

struct device;
Expand Down Expand Up @@ -40,16 +41,6 @@ int device_property_read_string_array(struct device *dev, const char *propname,
int device_property_read_string(struct device *dev, const char *propname,
const char **val);

enum fwnode_type {
FWNODE_INVALID = 0,
FWNODE_OF,
FWNODE_ACPI,
};

struct fwnode_handle {
enum fwnode_type type;
};

bool fwnode_property_present(struct fwnode_handle *fwnode, const char *propname);
int fwnode_property_read_u8_array(struct fwnode_handle *fwnode,
const char *propname, u8 *val,
Expand Down

0 comments on commit fe0a20a

Please sign in to comment.