Skip to content

Commit

Permalink
[TIPC]: Force linearization of non-linear sk_buffs
Browse files Browse the repository at this point in the history
This patch allows TIPC to process incoming messages that are
stored in a fragmented sk_buff, by forcing the linearization
of any such messages it receives.

Note: This is an interim solution to allow TIPC to operate with
Ethernet devices that generate non-linear buffers (such as the
gianfar driver), until such time as the rest of TIPC is enhanced
to handle sk_buffs with multiple data areas.

Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Allan Stephens authored and David S. Miller committed Apr 16, 2008
1 parent bdc82be commit fe13dda
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
12 changes: 12 additions & 0 deletions net/tipc/core.h
Original file line number Diff line number Diff line change
Expand Up @@ -337,4 +337,16 @@ static inline void buf_discard(struct sk_buff *skb)
kfree_skb(skb);
}

/**
* buf_linearize - convert a TIPC message buffer into a single contiguous piece
* @skb: message buffer
*
* Returns 0 on success.
*/

static inline int buf_linearize(struct sk_buff *skb)
{
return skb_linearize(skb);
}

#endif
6 changes: 6 additions & 0 deletions net/tipc/link.c
Original file line number Diff line number Diff line change
Expand Up @@ -1811,6 +1811,12 @@ void tipc_recv_msg(struct sk_buff *head, struct tipc_bearer *tb_ptr)
#endif
msg_dbg(msg,"<REC<");

/* Ensure message data is a single contiguous unit */

if (unlikely(buf_linearize(buf))) {
goto cont;
}

if (unlikely(msg_non_seq(msg))) {
link_recv_non_seq(buf);
continue;
Expand Down

0 comments on commit fe13dda

Please sign in to comment.