Skip to content

Commit

Permalink
[RFKILL]: Move rfkill_switch_all out of global header
Browse files Browse the repository at this point in the history
rfkill_switch_all shouldn't be called by drivers directly,
instead they should send a signal over the input device.

To prevent confusion for driver developers, move the
function into a rfkill private header.

Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ivo van Doorn authored and David S. Miller committed Oct 10, 2007
1 parent a50e2e3 commit fe242cf
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 4 deletions.
4 changes: 1 addition & 3 deletions include/linux/rfkill.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#define __RFKILL_H

/*
* Copyright (C) 2006 Ivo van Doorn
* Copyright (C) 2006 - 2007 Ivo van Doorn
* Copyright (C) 2007 Dmitry Torokhov
*
* This program is free software; you can redistribute it and/or modify
Expand Down Expand Up @@ -84,6 +84,4 @@ void rfkill_free(struct rfkill *rfkill);
int rfkill_register(struct rfkill *rfkill);
void rfkill_unregister(struct rfkill *rfkill);

void rfkill_switch_all(enum rfkill_type type, enum rfkill_state state);

#endif /* RFKILL_H */
2 changes: 2 additions & 0 deletions net/rfkill/rfkill-input.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
#include <linux/init.h>
#include <linux/rfkill.h>

#include "rfkill-input.h"

MODULE_AUTHOR("Dmitry Torokhov <dtor@mail.ru>");
MODULE_DESCRIPTION("Input layer to RF switch connector");
MODULE_LICENSE("GPL");
Expand Down
16 changes: 16 additions & 0 deletions net/rfkill/rfkill-input.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
/*
* Copyright (C) 2007 Ivo van Doorn
*/

/*
* This program is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 as published
* by the Free Software Foundation.
*/

#ifndef __RFKILL_INPUT_H
#define __RFKILL_INPUT_H

void rfkill_switch_all(enum rfkill_type type, enum rfkill_state state);

#endif /* __RFKILL_INPUT_H */
2 changes: 1 addition & 1 deletion net/rfkill/rfkill.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2006 Ivo van Doorn
* Copyright (C) 2006 - 2007 Ivo van Doorn
* Copyright (C) 2007 Dmitry Torokhov
*
* This program is free software; you can redistribute it and/or modify
Expand Down

0 comments on commit fe242cf

Please sign in to comment.